Enable PKCE in OIDC federated login flow #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
PR builder started |
ThaminduR
approved these changes
Apr 17, 2024
sadilchamishka
approved these changes
Apr 17, 2024
|
PR builder completed |
jenkins-is-staging
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/8715296338
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
This PR enables PKCE in OIDC federated login flow. In IDP configurations, a new checkbox has been introduced under Federated configurations to enable/disable PKCE in PR[1] and upon enabling the checkbox respective
code_verifierandcode_challengeparameters are added to the authentication and token requests.Related to wso2/api-manager#1613
Issue: wso2/product-is#20227
[1] wso2/carbon-identity-framework#4500