Modify the OIDC Authenticator to support Native SDK based Federation Flow in API Based Authentication #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to add-API-based-authentication # Conflicts: # components/org.wso2.carbon.identity.application.authenticator.oidc/src/main/java/org/wso2/carbon/identity/application/authenticator/oidc/OpenIDConnectAuthenticator.java
dhaura
changed the title
dhaura
changed the title
DMHP
reviewed
Oct 19, 2023
...java/org/wso2/carbon/identity/application/authenticator/oidc/OIDCAuthenticatorConstants.java
Outdated
Show resolved
Hide resolved
DMHP
reviewed
Oct 19, 2023
...java/org/wso2/carbon/identity/application/authenticator/oidc/OpenIDConnectAuthenticator.java
Outdated
Show resolved
Hide resolved
DMHP
approved these changes
Oct 19, 2023
This was referenced Oct 19, 2023
AnuradhaSK
reviewed
Apr 19, 2024
| /** | ||
| * Copyright (c) 2015, WSO2 LLC. (https://www.wso2.com) All Rights Reserved. | ||
| /* | ||
| * Copyright (c) 2015, WSO2 LLC. (http://www.wso2.com). |
There was a problem hiding this comment.
Changed year range should come in
AnuradhaSK
reviewed
Apr 19, 2024
| /** | ||
| * Copyright (c) 2013, WSO2 LLC. (https://www.wso2.com) All Rights Reserved. | ||
| /* | ||
| * Copyright (c) 2013, WSO2 LLC. (http://www.wso2.com). |
There was a problem hiding this comment.
Already addressed with dhaura@fee04f6
AnuradhaSK
reviewed
Apr 30, 2024
|
|
||
| IdentityProviderProperty[] identityProviderProperties = externalIdentityProvider.getIdpProperties(); | ||
| for (IdentityProviderProperty identityProviderProperty: identityProviderProperties) { | ||
| if (identityProviderProperty.getName().equals(IdPManagementConstants.IS_TRUSTED_TOKEN_ISSUER)) { |
There was a problem hiding this comment.
Use <constant>.equals(<variable>) pattern to avoid possible NPE
There was a problem hiding this comment.
Already addressed with 95e4f9c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
getContextIdentifier()in order to returnsessionDataKeyin Native SDK based Federation flows.requestAccessToken()in order to exchange an access tokens in Native SDK based Federation flows.NativeSDKBasedFederatedOAuthClientResponse.Additional Context
Mode 1: External IDP is configured in IS and the authentication is handled through IS by redirecting to the external IDP.Mode 2-Native SDK based Federation: The app uses the IdP SDK for a social login option, for example, Google; and federating to Google directly from the app. Then, the client will exchange an access token received directly from the IdP, for an OAuth2 token from the IS side. (This flow will be executed, only if the IdP is a trusted token issuer.)Related PRs
Related Issues