Add support for passwordExpiryTime in user claims on request #856

PasinduYeshan · 2024-09-10T08:42:25Z

Proposed changes in this pull request

Introduce new method to calculate password expiry time of a given user - getUserPasswordExpiryTime.
Introduce "PasswordExpiryEventListenerTest" to add passwordExpiryTime to user's claims map.

Related Issues

Deprecate and Replace v1/password-expired-users API with Scalable, Rule-Aware Version wso2/product-is#20999

…expired-users

codecov · 2024-11-27T11:07:48Z

Codecov Report

Attention: Patch coverage is 84.69388% with 15 lines in your changes missing coverage. Please review.

Project coverage is 50.76%. Comparing base (35e8681) to head (28c4788).
Report is 34 commits behind head on master.

Files with missing lines	Patch %	Lines
...tity/password/expiry/util/PasswordPolicyUtils.java	85.71%	2 Missing and 6 partials ⚠️
...d/expiry/listener/PasswordExpiryEventListener.java	87.50%	1 Missing and 4 partials ⚠️
...expiry/internal/EnforcePasswordResetComponent.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #856      +/-   ##
============================================
+ Coverage     50.32%   50.76%   +0.43%     
- Complexity     2385     2428      +43     
============================================
  Files           297      298       +1     
  Lines         17899    17887      -12     
  Branches       2558     2537      -21     
============================================
+ Hits           9008     9080      +72     
+ Misses         7747     7662      -85     
- Partials       1144     1145       +1

Flag	Coverage Δ
unit	`38.41% <84.69%> (+0.48%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

....expiry/src/main/java/org/wso2/carbon/identity/password/expiry/util/PasswordPolicyUtils.java

jenkins-is-staging · 2024-12-03T04:11:09Z

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12132798611

jenkins-is-staging · 2024-12-03T06:04:33Z

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12132798611
Status: success

jenkins-is-staging

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12132798611

jenkins-is-staging · 2024-12-13T04:48:48Z

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12309704989

jenkins-is-staging · 2024-12-13T04:49:47Z

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12309704989
Status: failure

jenkins-is-staging · 2024-12-13T05:11:01Z

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12309704989

jenkins-is-staging · 2024-12-13T05:12:00Z

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12309704989
Status: failure

PasinduYeshan · 2024-12-13T05:30:45Z

Failing with following error

Error:  The build could not read 4 projects -> [Help 1]
Error:    
Error:    The project org.wso2.carbon.identity.governance:org.wso2.carbon.identity.recovery.endpoint:1.11.23-SNAPSHOT (/home/runner/work/product-is/product-is/identity-governance/components/org.wso2.carbon.identity.recovery.endpoint/pom.xml) has 1 error
Error:      'dependencies.dependency.version' for org.springframework:spring-web:jar is missing. @ line 80, column 21
Error:    
Error:    The project org.wso2.carbon.identity.governance:org.wso2.carbon.identity.api.user.recovery:1.11.23-SNAPSHOT (/home/runner/work/product-is/product-is/identity-governance/components/org.wso2.carbon.identity.api.user.recovery/pom.xml) has 1 error
Error:      'dependencies.dependency.version' for org.springframework:spring-web:jar is missing. @ line 150, column 21
Error:    
Error:    The project org.wso2.carbon.identity.governance:org.wso2.carbon.identity.user.endpoint:1.11.23-SNAPSHOT (/home/runner/work/product-is/product-is/identity-governance/components/org.wso2.carbon.identity.user.endpoint/pom.xml) has 1 error
Error:      'dependencies.dependency.version' for org.springframework:spring-web:jar is missing. @ line 85, column 21
Error:    
Error:    The project org.wso2.carbon.identity.governance:org.wso2.carbon.identity.api.user.governance:1.11.23-SNAPSHOT (/home/runner/work/product-is/product-is/identity-governance/components/org.wso2.carbon.identity.api.user.governance/pom.xml) has 1 error
Error:      'dependencies.dependency.version' for org.springframework:spring-web:jar is missing. @ line 205, column 21
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException

jenkins-is-staging · 2024-12-13T05:36:08Z

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12310234311

PasinduYeshan · 2024-12-13T06:43:14Z

...main/java/org/wso2/carbon/identity/password/expiry/listener/PasswordExpiryEventListener.java

+                        .put(PasswordPolicyConstants.PASSWORD_EXPIRY_TIME_CLAIM, String.valueOf(expiryTime)));
+            }
+        } catch (PostAuthenticationFailedException e) {
+            throw new UserStoreException("Error while retrieving password expiry time.", e);


Check if these are logged.

...main/java/org/wso2/carbon/identity/password/expiry/listener/PasswordExpiryEventListener.java

jenkins-is-staging · 2024-12-13T07:24:32Z

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12310234311
Status: success

jenkins-is-staging

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12310234311

....expiry/src/main/java/org/wso2/carbon/identity/password/expiry/util/PasswordPolicyUtils.java

jenkins-is-staging · 2024-12-13T11:16:11Z

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12314642239

jenkins-is-staging · 2024-12-13T13:10:31Z

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12314642239
Status: success

jenkins-is-staging

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12314642239

PasinduYeshan added 2 commits September 10, 2024 14:09

Introduce method to return given user's password expiry time.

4a1839a

Merge remote-tracking branch 'upstream/master' into feature/password-…

7a8b7c3

…expired-users

Add more unit tests

a61a5d7

KD23243 reviewed Nov 29, 2024

View reviewed changes

....expiry/src/main/java/org/wso2/carbon/identity/password/expiry/util/PasswordPolicyUtils.java Outdated Show resolved Hide resolved

PasinduYeshan added 2 commits November 29, 2024 13:05

Refactor to use Optional

76bdf04

Return current time when lastPasswordUpdateTime is null.

feab5d9

This was referenced Dec 2, 2024

Add password expiry time to SCIM2 users response when requested wso2-extensions/identity-inbound-provisioning-scim2#583

Closed

Introduce password expiry time claim wso2/carbon-identity-framework#6170

Merged

jenkins-is-staging approved these changes Dec 3, 2024

View reviewed changes

PasinduYeshan added 5 commits December 4, 2024 15:30

Refactor

16567bc

Introduce PasswordExpiryEventListener.

4327adf

Add imports.

1fae298

Update getUserPasswordExpiryTime to accept gov configs.

a44564e

Add unit tests for PasswordExpiryEventListener

8e378b5

PasinduYeshan changed the title ~~Introduce method to return given user's password expiry time.~~ Add support for passwordExpiryTime in user claims on request Dec 9, 2024

PasinduYeshan commented Dec 13, 2024

View reviewed changes

amanda-ariyaratne reviewed Dec 13, 2024

View reviewed changes

...main/java/org/wso2/carbon/identity/password/expiry/listener/PasswordExpiryEventListener.java Outdated Show resolved Hide resolved

jenkins-is-staging approved these changes Dec 13, 2024

View reviewed changes

Change the exception type and refactor

0886166

amanda-ariyaratne reviewed Dec 13, 2024

View reviewed changes

....expiry/src/main/java/org/wso2/carbon/identity/password/expiry/util/PasswordPolicyUtils.java Outdated Show resolved Hide resolved

Refactor the code.

28c4788

amanda-ariyaratne approved these changes Dec 13, 2024

View reviewed changes

jenkins-is-staging approved these changes Dec 13, 2024

View reviewed changes

PasinduYeshan merged commit 48c8969 into wso2-extensions:master Dec 14, 2024
5 checks passed

PasinduYeshan mentioned this pull request Dec 16, 2024

Revert "Add support for passwordExpiryTime in user claims on request" #894

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for passwordExpiryTime in user claims on request #856

Add support for passwordExpiryTime in user claims on request #856

PasinduYeshan commented Sep 10, 2024 •

edited

Loading

codecov bot commented Nov 27, 2024 •

edited

Loading

jenkins-is-staging commented Dec 3, 2024

jenkins-is-staging commented Dec 3, 2024

jenkins-is-staging left a comment

jenkins-is-staging commented Dec 13, 2024

jenkins-is-staging commented Dec 13, 2024

jenkins-is-staging commented Dec 13, 2024

jenkins-is-staging commented Dec 13, 2024

PasinduYeshan commented Dec 13, 2024

jenkins-is-staging commented Dec 13, 2024

PasinduYeshan Dec 13, 2024

jenkins-is-staging commented Dec 13, 2024

jenkins-is-staging left a comment

jenkins-is-staging commented Dec 13, 2024

jenkins-is-staging commented Dec 13, 2024

jenkins-is-staging left a comment

Add support for passwordExpiryTime in user claims on request #856

Add support for passwordExpiryTime in user claims on request #856

Conversation

PasinduYeshan commented Sep 10, 2024 • edited Loading

Proposed changes in this pull request

Related Issues

codecov bot commented Nov 27, 2024 • edited Loading

Codecov Report

jenkins-is-staging commented Dec 3, 2024

jenkins-is-staging commented Dec 3, 2024

jenkins-is-staging left a comment

Choose a reason for hiding this comment

jenkins-is-staging commented Dec 13, 2024

jenkins-is-staging commented Dec 13, 2024

jenkins-is-staging commented Dec 13, 2024

jenkins-is-staging commented Dec 13, 2024

PasinduYeshan commented Dec 13, 2024

jenkins-is-staging commented Dec 13, 2024

PasinduYeshan Dec 13, 2024

Choose a reason for hiding this comment

jenkins-is-staging commented Dec 13, 2024

jenkins-is-staging left a comment

Choose a reason for hiding this comment

jenkins-is-staging commented Dec 13, 2024

jenkins-is-staging commented Dec 13, 2024

jenkins-is-staging left a comment

Choose a reason for hiding this comment

PasinduYeshan commented Sep 10, 2024 •

edited

Loading

codecov bot commented Nov 27, 2024 •

edited

Loading