Improvement to honour the locale for email notifications. #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/9868033876
Thisara-Welmilla
force-pushed
the
Honour-locale-for-notifications
branch
from
9c3a092 to
3f6bff6
Compare
Thisara-Welmilla
force-pushed
the
Honour-locale-for-notifications
branch
from
3f6bff6 to
92049ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Improvement to resolve locale attribute value of the authenticated user:
If a local user exists for the authenticated user, retrieve the locale value from the userStore. If no local user exists (either because it is the first time federated authentication or JIT provisioning is disabled), check the event properties for a local value, which will be set by the email authenticator step if there is a locale claim as an IDP claim. If neither of these conditions are met, set the default locale value.