[Feature] - BE 테스트 개선 스프링 컨텍스트 캐싱 최적화 #625
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Libienz
requested review from
hangillee,
eunjungL,
nak-honest and
slimsha2dy
2 tasks
Test Results 30 files 30 suites 1m 8s ⏱️ Results for commit eef17d5. |
eunjungL
approved these changes
Dec 24, 2024
| import org.springframework.boot.test.web.server.LocalServerPort; | ||
|
|
||
| @SpringBootTest(webEnvironment = WebEnvironment.RANDOM_PORT) | ||
| public abstract class AbstractControllerIntegrationTest extends AbstractIntegrationTest { |
There was a problem hiding this comment.
매번 불필요하게 반복되던 공통 로직이 잘 모였군요 👍
네이밍은 전 지금도 좋은 것 같습니다. 조금 긴 감이 있긴한데 오히려 명확한게 좋다고 생각해요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 작업 내용
🙈 참고 사항
추상 클래스 계층 구조를 통해 서비스 통합 테스트, 컨트롤러 통합 테스트 환경을 통일하도록 했습니다.
이전에는 10개의 애플리케이션 컨텍스트가 전체 테스트에 소모되었지만 최적화 후 4개로 줄어들었습니다.
테스트 수행시간은 5번씩 측정을 진행해보았을 때 약 39초에서 32초로 18프로 정도 개선되었습니다. (제 로컬 기준)
추상클래스 이름 추천받습니다 인스턴스화가 불가능한 추상클래스라는 점을 명세에 강조하기 위해서 Abstract을 붙여보았어요 다른 좋은 이름 생각나시면 말씀 부탁드리겠습니다.