Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] refactor: 요청 제한 관련 코드 제거 #983

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

nayonsoso
Copy link
Contributor


🚀 어떤 기능을 구현했나요 ?

  • 요청 제한과 관련된 코드를 제거했습니다.

🔥 어떻게 해결했나요 ?

  • 관련 코드가 하나의 패키지에 있어서 수월했습니다👍

📚 참고 자료, 할 말

  • application-dev 나 application-prod 에도 관련 변수 제거했습니다.

Copy link

Test Results

157 tests   - 3   154 ✅  - 3   4s ⏱️ -1s
 58 suites  - 1     3 💤 ±0 
 58 files    - 1     0 ❌ ±0 

Results for commit 7a6d0d2. ± Comparison against base commit 0522c5f.

This pull request removes 3 tests.
reviewme.config.requestlimit.RequestLimitInterceptorTest ‑ POST_요청이_아니면_통과한다()
reviewme.config.requestlimit.RequestLimitInterceptorTest ‑ 특정_POST_요청이_처음이_아니며_최대_빈도보다_작을_경우_빈도를_1증가시킨다()
reviewme.config.requestlimit.RequestLimitInterceptorTest ‑ 특정_POST_요청이_처음이_아니며_최대_빈도보다_클_경우_예외를_발생시킨다()

@donghoony
Copy link
Contributor

해당 PR은 #944 (review) 를 확인하면 좋습니다

@donghoony donghoony merged commit 1c99dd8 into develop Nov 28, 2024
6 of 7 checks passed
@donghoony donghoony deleted the remove-request-limit branch December 18, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants