Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] 상세 리뷰 페이지 : url router 연동, 변경된 디자인 반영 및 서버에서 api를 연동 #91

Merged
merged 30 commits into from
Jul 25, 2024
Merged

[FE] 상세 리뷰 페이지 : url router 연동, 변경된 디자인 반영 및 서버에서 api를 연동 #91

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
9c72fb9
fix: stylelint를 통한 css 속성 정렬 기능 오류 수정
BadaHertz52 Jul 20, 2024
e3e33a6
refactor: stylelint 적용에 따른 css 속성 정렬
BadaHertz52 Jul 20, 2024
ee8b83d
Merge branch 'feat/71-detailed_review_page' of https://github.com/woo…
BadaHertz52 Jul 23, 2024
0a2ab6a
fix : 절대 경로 사용 시 오류 수정
BadaHertz52 Jul 23, 2024
6a51f29
Merge branch 'develop' of https://github.com/woowacourse-teams/2024-r…
BadaHertz52 Jul 23, 2024
8750b3f
chore: eslintrc.cjs 에서 불필요한 코드 삭제
BadaHertz52 Jul 23, 2024
b211040
style: eslint 적용에 따른 리뷰 상세페이지 import 순서 정리
BadaHertz52 Jul 23, 2024
eb186cc
refactor: formatDate를 utils/date 파일로 이동
BadaHertz52 Jul 23, 2024
aed7cb6
design: theme에 colors,, fontSize 변경 및 borderRadius 추가
BadaHertz52 Jul 23, 2024
1bff507
feat: MultilineTextViewer 컴포넌트 생성
BadaHertz52 Jul 23, 2024
ae2d822
feat: 깃허브 저장소 이미지 컴포넌트 생성
BadaHertz52 Jul 23, 2024
54e060f
feat: 리뷰와 관련된 날짜 UI 컴포넌트 생성
BadaHertz52 Jul 23, 2024
1f13060
featr: LockButton 삭제 LockToggle 추가
BadaHertz52 Jul 23, 2024
018934e
refactor: 피그마 디자인 변경에 따른 ReviewDescription 변경
BadaHertz52 Jul 23, 2024
759c8e3
feat: ReviewComment 컴포넌트 생성
BadaHertz52 Jul 23, 2024
daf28b0
refactor: ReviewViewSection -> ReviewSection 으로 변경 및 리팩토링
BadaHertz52 Jul 23, 2024
b92702a
refactor: DetailedReviewPage 리팩토링
BadaHertz52 Jul 23, 2024
1a553a8
refactor: review에 대한 타입 변경
BadaHertz52 Jul 24, 2024
9c4e0d3
design : ReviewDate의 클론 스타일 적용
BadaHertz52 Jul 24, 2024
cecbf0c
feat: KeywordSection 컴포넌트 생성
BadaHertz52 Jul 24, 2024
def6460
feat: ReviewSectionHeader 컴포넌트 생성 및 적용
BadaHertz52 Jul 24, 2024
e3ce3db
design : 리뷰 상세페이지에 width 변경
BadaHertz52 Jul 24, 2024
bba11c1
refactor: DetailedReview의 목데이터 변경 및 리팩토링
BadaHertz52 Jul 24, 2024
d038667
design : formWidth를 theme에 추가 및 리뷰 작성/리뷰 상세 페이지에 적용
BadaHertz52 Jul 24, 2024
06edaa7
fix: Layout에서 가로 스크롤 생기는 오류 수정
BadaHertz52 Jul 24, 2024
ff012ee
feat: 리뷰 상페이지 router에 라우터 파라미터 적용 및 관련 설정 변경
BadaHertz52 Jul 24, 2024
e198727
docs: 변수명 변경 (isLock -> isPublic)
BadaHertz52 Jul 24, 2024
47598e7
refactor: 깃헙 저장소 로고 주소 변수명 변경
BadaHertz52 Jul 24, 2024
c8aa6a5
Merge branch 'develop' of https://github.com/woowacourse-teams/2024-r…
BadaHertz52 Jul 25, 2024
4dd06f5
refactor: 리뷰 상세 페이지 api 변경에 따른 수정
BadaHertz52 Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/components/common/ReviewDate/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const ReviewDate = ({ date, dateTitle }: ReviewDateProps) => {
<S.ReviewDate>
<S.ClockImg src={ClockIcon} alt="시계 아이콘" />
<span>{dateTitle}</span>
<span>:</span>
<S.Colon>:</S.Colon>
<span>
{year}-{month}-{day}
</span>
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/components/common/ReviewDate/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ export const ReviewDate = styled.div`
display: flex;
align-items: center;
font-size: 1.6rem;
`;

span:nth-child(2) {
margin: 0 1rem;
}
export const Colon = styled.span`
margin: 0 1rem;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nth-child 말고 별도의 named component로 지정한 부분 좋습니다👍

`;