Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] refactor: NativeQuery를 JPQL로 변환 #808

Merged
merged 1 commit into from
Oct 11, 2024
Merged

[BE] refactor: NativeQuery를 JPQL로 변환 #808

merged 1 commit into from
Oct 11, 2024

Conversation

donghoony
Copy link
Contributor

  • JPQL에서 지원하는 다양한 기능을 사용할 수 있는데, 의존성을 떼서 조인하면 Native을 써야 하는 줄 알았네요. 기존 nativeQuery를 모두 JPQL로 전환하고, 이를 통해 컴파일 시간에 오류를 확인할 수 있도록 합니다. SQL을 작성하지 않으니 MySQL하고도 호환될 것이라고 기대해요.

@donghoony donghoony self-assigned this Oct 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 10, 2024 •
edited
Loading

Test Results

146 tests  ±0   146 ✅ ±0   4s ⏱️ -1s
 55 suites ±0     0 💤 ±0 
 55 files   ±0     0 ❌ ±0 

Results for commit 5b2e761. ± Comparison against base commit 7e5564b.

♻️ This comment has been updated with latest results.

Kimprodp
Kimprodp approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@Kimprodp Kimprodp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 굿 ~👍 이참에 프로젝션도 공부해야겠어요

@Kimprodp Kimprodp mentioned this pull request Oct 10, 2024
Merged
skylar1220
skylar1220 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@skylar1220 skylar1220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아루 고수고수고🌿
이렇게 하면 도커로 환경 통일을 하지 않아도 되는지 확인해봐야겠네용!

nayonsoso
nayonsoso approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@nayonsoso nayonsoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른 수정 좋아요😊
이게 바로 백엔드 컨트리뷰터 1위의 위엄!!

@donghoony donghoony force-pushed the be/refactor/native-to-jpql branch from 61e639a to 5b2e761 Compare October 11, 2024 08:16
@donghoony
Copy link
Contributor Author

이 PR이 머지되면 아래 PR은 잠정 중단됩니다:

@donghoony donghoony mentioned this pull request Oct 11, 2024
Draft
@donghoony donghoony merged commit b6d03d1 into develop Oct 11, 2024
2 checks passed
@donghoony donghoony deleted the be/refactor/native-to-jpql branch October 11, 2024 08:38
@donghoony donghoony mentioned this pull request Oct 12, 2024
Closed
skylar1220 pushed a commit that referenced this pull request Nov 5, 2024
@donghoony @skylar1220
[BE] refactor: NativeQuery JPQL로 변환 및 value 파라미터 생략 (#808)
a8076b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kimprodp Kimprodp Kimprodp approved these changes

@skylar1220 skylar1220 skylar1220 approved these changes

@nayonsoso nayonsoso nayonsoso approved these changes

Assignees

@donghoony donghoony

Labels
✨ BE 🛠️ 리팩터링
Projects
2024-review-me
Status: Done
Milestone
6차 스프린트: 최종장
Development

Successfully merging this pull request may close these issues.
4 participants
@donghoony @nayonsoso @skylar1220 @Kimprodp