Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] refactor: DTO에서 Enum 사용하도록 수정 #1012

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

donghoony
Copy link
Contributor

🚀 어떤 기능을 구현했나요 ?

  • 기존 DTO에서는 Enum을 직접 사용했었는데, 몇몇 부분에서 String으로 사용하면서 .name()를 불필요하게 부르고 있는 것을 확인했어요. 이를 Enum을 직접 사용하도록 수정했습니다. 통일감도 지키고요!

🔥 어떻게 해결했나요 ?

  • 기능 상 변화는 없습니다 !
  • Dto에서 String을 Enum 타입으로 바꾸기

📝 어떤 부분에 집중해서 리뷰해야 할까요?

  • 문자열은 실수할 여지가 있다고 생각했어요. 자유롭게 생각 나눠주세요~

📚 참고 자료, 할 말

@donghoony donghoony self-assigned this Dec 18, 2024
@donghoony donghoony changed the title [BE] DTO에서 Enum 사용하도록 수정 [BE] refactor: DTO에서 Enum 사용하도록 수정 Dec 18, 2024
Copy link

github-actions bot commented Dec 18, 2024

Test Results

157 tests  ±0   154 ✅ ±0   4s ⏱️ ±0s
 58 suites ±0     3 💤 ±0 
 58 files   ±0     0 ❌ ±0 

Results for commit 6548afe. ± Comparison against base commit 69b507a.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@nayonsoso nayonsoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런 세심한 부분까지 확인하는 것 너무 좋네요😊
enum의 전체적인 컨벤션을 맞추는 김에, OptionType도 컨벤션 맞추면 더 좋을 것 같아요!

Copy link
Contributor

@skylar1220 skylar1220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants