Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.2.0/AN-FEAT, AN-UI] 포켓몬 스탯 프로그레스 바에 애니메이션 적용 #484

Merged
merged 23 commits into from
Dec 19, 2024

Conversation

sh1mj1
Copy link
Contributor

@sh1mj1 sh1mj1 commented Dec 6, 2024

작업 영상

default.webm

작업한 내용

  • 포켓몬 스탯 프로그레스 바에 애니메이션 적용

PR 포인트

🚀Next Feature

글쎄요...?

sh1mj1 added 20 commits December 6, 2024 17:20
포켓로그 인 게임에서 보여주는 것으로 정의한다
현재 화면과 같은 포켓몬이면 토스트 메시지
다른 포켓몬이면 화면 이동
@sh1mj1 sh1mj1 added AN_FEAT ✨ 안드 새로운 기능 AN_UI 🎨 안드 UI 작업 labels Dec 6, 2024
@sh1mj1 sh1mj1 self-assigned this Dec 6, 2024
Copy link
Contributor

@murjune murjune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

애니메이션 좋은데열~~ ㅋㅋㅋ

Comment on lines +37 to +44
binding.progressBarStat.apply {
startAnimation(
animation(from = 0f, to = stat.amount.toFloat()).apply {
duration = ANIMATION_DURATION
},
)
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 생각보다 간단하게 되는 군요 ㅋㅋㅋ

Comment on lines 18 to 21
progressBar.progress = value.toInt()
progressBar.apply {
progress = value.toInt()
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
progressBar.progress = value.toInt()
progressBar.apply {
progress = value.toInt()
}
progressBar.progress = value.toInt()

중복되는 내용이 있습니다!

Copy link
Contributor

@JoYehyun99 JoYehyun99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무 귀여워용~

Copy link
Contributor

@kkosang kkosang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

대박 앱이 점점 살아움직인다 !! 고생하셨습니다 👍

@sh1mj1 sh1mj1 merged commit 07fd25a into an/develop Dec 19, 2024
2 checks passed
@sh1mj1 sh1mj1 deleted the an/refactor/pokemon-stats-animation branch December 19, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AN_FEAT ✨ 안드 새로운 기능 AN_UI 🎨 안드 UI 작업 v1.2.0 🏷️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants