♻️ change version of user comment list #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
HaiSeong
approved these changes
Dec 10, 2024
| @GetMapping("/mine") | ||
| public List<CommentOfUserResponse> readCommentsOfMe(@LoginUser UserInfo userInfo) { | ||
| return commentService.readCommentsOfUser(userInfo); | ||
| @GetMapping(value = "/mine", produces = "application/vnd.pengcook.v1+json") |
There was a problem hiding this comment.
이건 리뷰 보다는 생각해볼만한 거리인것 같은데 추후에도 계속 모든 메서드에 버전이 추가되면 항상 produces = "application/vnd.pengcook.v1+json이 반복되게 될것 같아 나중에 불편하지 않을까 생각이 들었어요. 다음 회의때 같이 고민해보면 좋지 않을까 생각합니다.
There was a problem hiding this comment.
맞는 말이네요. 작성도 불편하고 확인도 불편하겠어요!
회의록을 미리 만들어서 의견 업로드 해뒀습니다~
다음 회의 때 같이 이야기해보아요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
유저의 댓글 리스트를 확인하는 request의 헤더에 버전을 추가했습니다!