✨ follow user #431
Open
✨ follow user #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
github-actions
bot
commented
Dec 5, 2024
•
github-actions
bot
commented
- 유저 프로필 조회 시, 팔로잉, 팔로워 수 반환하도록 수정
- 유저 팔로우 구현
- 유저 언팔로우 구현
- 본인 계정의 팔로워 삭제 구현
- 유저 삭제에 따른 UserFollow 정리(팔로우 데이터 삭제, 팔로워, 팔로잉 수 수정)
|
hyxrxn
reviewed
Dec 17, 2024
Comment on lines
-27
to
+28
| 0, | ||
| 0, | ||
| user.getUserFollowerCount(), | ||
| user.getUserFolloweeCount(), |
hyxrxn
requested changes
Dec 22, 2024
Comment on lines
+43
to
+49
| @Column(nullable = false) | ||
| @ColumnDefault("0") | ||
| private long userFollowerCount; | ||
|
|
||
| @Column(nullable = false) | ||
| @ColumnDefault("0") | ||
| private long userFolloweeCount; |
There was a problem hiding this comment.
변수명 앞에 user는 빼도 되지 않을까요???
+) 저희 DB 수정도 필요하겠네요....!!
| import lombok.NoArgsConstructor; | ||
|
|
||
| @Entity | ||
| @Table(uniqueConstraints = {@UniqueConstraint(columnNames = {"follower_id", "followee_id"})}) |
Comment on lines
+35
to
+37
| public UserFollow(User follower, User followee) { | ||
| this(0L, follower, followee); | ||
| } |
There was a problem hiding this comment.
follower와 followee가 같은지 확인하지 않아도 될까요?
There was a problem hiding this comment.
좋네요. �유니크 키가 있긴 하지만 validate 함수를 만들어 검사하는것이 빠르게 예외를 발생시킬 방법인것 같아요
Comment on lines
+139
to
+148
| List<UserFollow> followings = userFollowRepository.findAllByFollowerId(userInfo.getId()); | ||
| for (UserFollow userFollow : followings) { | ||
| userFollow.getFollowee().decreaseUserFollowerCount(); | ||
| userFollowRepository.delete(userFollow); | ||
| } | ||
| List<UserFollow> followers = userFollowRepository.findAllByFolloweeId(userInfo.getId()); | ||
| for (UserFollow userFollow : followers) { | ||
| userFollow.getFollower().decreaseUserFolloweeCount(); | ||
| userFollowRepository.delete(userFollow); | ||
| } |
There was a problem hiding this comment.
생각해보니 유저가 탈퇴했을 때 좋아요 개수는 변하지 않지만 팔로우 개수는 변하는군요...!!!
다음 회의 때 이야기해보면 좋을 것 같아요
There was a problem hiding this comment.
제가 보기에는 팔로우 수가 줄어드는게 맞는것 같아요. 👍
회의에서 이야기 해봅시다
Comment on lines
+304
to
+307
| assertAll( | ||
| () -> assertThat(deletedUserFollower).isTrue(), | ||
| () -> assertThat(deletedUserFollowee).isTrue() | ||
| ); |
There was a problem hiding this comment.
위 코멘트랑 관련있는데 삭제시 팔로워/팔로이의 숫자가 변하는게 정책이라면 이를 함께 확인하지 않아도 될까요?
HaiSeong
reviewed
Dec 22, 2024
Comment on lines
+152
to
+155
| @Transactional | ||
| public UserFollowResponse followUser(long followerId, long followeeId) { | ||
| User follower = userRepository.findById(followerId) | ||
| .orElseThrow(() -> new NotFoundException("팔로워 정보를 조회할 수 없습니다.")); |
Comment on lines
+35
to
+37
| public UserFollow(User follower, User followee) { | ||
| this(0L, follower, followee); | ||
| } |
There was a problem hiding this comment.
좋네요. �유니크 키가 있긴 하지만 validate 함수를 만들어 검사하는것이 빠르게 예외를 발생시킬 방법인것 같아요
Comment on lines
+10
to
+14
| Optional<UserFollow> findByFollowerIdAndFolloweeId(Long followerId, Long followeeId); | ||
|
|
||
| List<UserFollow> findAllByFollowerId(long followerId); | ||
|
|
||
| List<UserFollow> findAllByFolloweeId(long followeeId); |
There was a problem hiding this comment.
UserFollow 도 authorAble을 구현해야 할까요?
사용자가 차단 한 상황에 팔로우 목록에서 보여줄지 고민이 필요할것 같아요.
또는 차단 했을때 팔로우를 지울지도 고민이 필요해보여요. 이 부분은 정책 회의때 이야기 해봐야 할것 같네요.
Comment on lines
+139
to
+148
| List<UserFollow> followings = userFollowRepository.findAllByFollowerId(userInfo.getId()); | ||
| for (UserFollow userFollow : followings) { | ||
| userFollow.getFollowee().decreaseUserFollowerCount(); | ||
| userFollowRepository.delete(userFollow); | ||
| } | ||
| List<UserFollow> followers = userFollowRepository.findAllByFolloweeId(userInfo.getId()); | ||
| for (UserFollow userFollow : followers) { | ||
| userFollow.getFollower().decreaseUserFolloweeCount(); | ||
| userFollowRepository.delete(userFollow); | ||
| } |
There was a problem hiding this comment.
제가 보기에는 팔로우 수가 줄어드는게 맞는것 같아요. 👍
회의에서 이야기 해봅시다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.