Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ update recipe #409

Merged
merged 4 commits into from
Oct 23, 2024
Merged

✨ update recipe #409

merged 4 commits into from
Oct 23, 2024

Conversation

HaiSeong
Copy link

  1. 변경감지를 이용한 레시피 수정
  2. 기존의 레시피 스탭들을 삭제
  3. 새로운 레시피 스탭들을 생성

@HaiSeong HaiSeong self-assigned this Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Overall Project 90.74% -0.82% 🍏
Files changed 76.13% 🍏

File Coverage
RecipeUpdateRequest.java 100% 🍏
RecipeController.java 100% 🍏
RecipeService.java 87.02% -0.97% 🍏
Recipe.java 73.89% -20.38% 🍏

@HaiSeong @hyxrxn
🐛 restdoc field
e9d7e10 
Co-authored-by: hyxrxn <[email protected]>
geoje
geoje approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@geoje geoje left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Offline Review ✨LGTM🎇!! 👍

@github-actions GitHub Actions
Copy link
Contributor

Overall Project 90.85% -0.71% 🍏
Files changed 81.18% 🍏

File Coverage
RecipeUpdateRequest.java 100% 🍏
RecipeController.java 100% 🍏
RecipeService.java 88.01% 🍏
Recipe.java 73.89% -20.38% 🍏

hyxrxn
hyxrxn approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@hyxrxn hyxrxn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠르게 구현해주셨군요
오프라인 리뷰에서 변경사항이 많았지만... 👀
암튼 잘 완성했죠?
스웨거까지...
고생하셨습니다
💯👍👍
쌍따봉 드립니다

@github-actions GitHub Actions
Copy link
Contributor

Overall Project 90.85% -0.71% 🍏
Files changed 81.18% 🍏

File Coverage
RecipeUpdateRequest.java 100% 🍏
RecipeController.java 100% 🍏
RecipeService.java 88.01% 🍏
Recipe.java 73.89% -20.38% 🍏

@HaiSeong HaiSeong merged commit a202c50 into be/dev Oct 23, 2024
1 check passed
@HaiSeong HaiSeong deleted the be/feature/408 branch October 23, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyxrxn hyxrxn hyxrxn approved these changes

@geoje geoje geoje approved these changes

Assignees

@HaiSeong HaiSeong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HaiSeong @geoje @hyxrxn