♻ add field to MainRecipeResponse #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
oshyun00
reviewed
Aug 16, 2024
| RecipeDataResponse firstResponse = groupedResponses.getFirst(); | ||
| boolean mine = firstResponse.authorId() == userInfo.getId(); |
There was a problem hiding this comment.
이 부분은 이전에 아토가 얘기한대로 User나 UserInfo에서 확인하도록 해도 좋을 것 같습니다.
(도메인 담당이 다르고 향후 리팩토링할 부분인 것 같아 일단 두었습니다!)
|
hyxrxn
approved these changes
Aug 16, 2024
| .sorted(Comparator.comparing(MainRecipeResponse::recipeId).reversed()) | ||
| .collect(Collectors.toList()); | ||
| } | ||
|
|
||
| private MainRecipeResponse getMainRecipeResponse(List<RecipeDataResponse> groupedResponses) { | ||
| private MainRecipeResponse getMainRecipeResponse(UserInfo userInfo, List<RecipeDataResponse> groupedResponses) { |
There was a problem hiding this comment.
MainRecipeResponse 생성자에서 userInfo 와 groupedResponses 를 파라미터로 받아서 this로 생성해보는 건 어떨까요?
static 메서드가 이제는 필요한 것 같기도 하네요....
다음 오프라인 코드리뷰 때 얘기 한 번 해보시죠!
There was a problem hiding this comment.
서비스 클래스에서 DTO로 변경하는 과정이 과하게 느껴지기는 하네요.
팀 컨벤션 정했을 때 static 메서드는 최대한 쓰지 않는 것으로 얘기했던 것 같아 그 부분은 아직 적용하지 않고,
대신 userInfo와 groupedResponses를 가공한 데이터를 파라미터로 하는 MainRecipeResponse 생성자를 추가했습니다.
static메서드를 쓰게 되면 DTO 변환들이 좀 더 깔끔해질 것 같아요!👍🏻
There was a problem hiding this comment.
오오 이정도도 많이 보기 좋아졌다고 생각합니다!!! 👍
|
|
geoje
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MainRecipeResponse에 레시피가 조회자(로그인된 사용자)가 작성한 글인지 여부를 나타내는 필드
mine을 추가했습니다.이 과정에서 현재 미사용중이면서 DTO 변경에 영항받는
readRecipesOfCategory,readRecipesOfUser메서드도 삭제했습니다.