✨ delete recipe #304
Merged
✨ delete recipe #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
geoje
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
레시피 서비스가 뚱땡이가 되어버렸군요!
앞으로 저도 상호의존 하지않도록 주의해야겠네요~
만들어진 서비스들 잘 활용하면서 삭제 완성해주셨네요!
레시피를 외래키로 가지는 도메인이 추가되는 일이 흔치는 않겠지만 만약 그런 상황이 왔을 때
- 테스트코드는 다 통과하는데 개발 서버에서 새로운 도메인을 생성하고 레시피를 삭제할 때 외래키 문제가 터질 것 같은데...
라는 느낌을 받았어요!
지금은 어쩔 수 없지만 여러 상황에 또 다른 삭제 방법도 있을 것 같아서 같이 공부해보면 좋을 것 같네요!
고생하셨습니다 엘라~~
hyxrxn
approved these changes
Aug 16, 2024
| @@ -147,4 +169,10 @@ private Pageable getValidatedPageable(int pageNumber, int pageSize) { | |||
| } | |||
| return PageRequest.of(pageNumber, pageSize); | |||
| } | |||
|
|
|||
| private void verifyUserCanDeleteRecipe(UserInfo userInfo, Recipe recipe) { | |||
| if (recipe.getAuthor().getId() != userInfo.getId()) { | |||
There was a problem hiding this comment.
UserInfo가 할 수 있을 것 같은데... 아쉽네요
이 부분이 자꾸 눈에 걸리는군요
Comment on lines
+143
to
+146
| assertAll( | ||
| () -> assertThat(recipeRepository.findById(1L)).isEmpty(), | ||
| () -> assertThat(recipeRepository.count()).isEqualTo(INITIAL_RECIPE_COUNT - 1) | ||
| ); |
There was a problem hiding this comment.
레시피 관련 다른 정보들도 다 지워진다는 것은 확인하지 않아도 괜찮을까요?
어느정도 테스트를 하면 좋을지에 대해 어떻게 결론이 났는지 궁금합니다!
레시피를 무사히 지울 수 있다는 거면 참조가 잘 끊어졌다는 뜻이니까 이만큼만 봐도 되려나요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.