refactor: 불필요한 sender 파라미터 삭제

woowacourse-teams · Oct 7, 2024 · 58691ce · 58691ce
1 parent 1435ea6
commit 58691ce
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/backend/src/main/java/com/ody/notification/domain/message/DirectMessage.java b/backend/src/main/java/com/ody/notification/domain/message/DirectMessage.java
@@ -6,7 +6,8 @@
 
 public record DirectMessage(Message message) {
 
-    public static DirectMessage createMessageToOther(Mate sender, Mate receiver, Notification recipientNotification) {
+    public static DirectMessage createMessageToOther(Mate receiver, Notification recipientNotification) {
+        Mate sender = recipientNotification.getMate();
         Message message = Message.builder()
                 .putData("type", recipientNotification.getType().name())
                 .putData("nickname", sender.getNickname().getValue())

diff --git a/backend/src/main/java/com/ody/notification/service/NotificationService.java b/backend/src/main/java/com/ody/notification/service/NotificationService.java
@@ -105,7 +105,7 @@ public void sendNudgeMessage(Mate requestMate, Mate nudgedMate) {
         Notification nudgeNotification = notificationRepository.save(Notification.createNudge(requestMate));
         fcmPushSender.sendNudgeMessage(
                 nudgeNotification,
-                DirectMessage.createMessageToOther(requestMate, nudgedMate, nudgeNotification)
+                DirectMessage.createMessageToOther(nudgedMate, nudgeNotification)
         );
     }