전송 실패한 알림에 대한 로깅 구체화 #763
Merged
전송 실패한 알림에 대한 로깅 구체화 #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ay-eonii
approved these changes
Oct 24, 2024
| log.info("Removing all unregistered tokens: {}", failedWith404Tokens); | ||
| List<String> tokens = failedWith404Tokens.stream().map(FcmToken::getToken).toList(); | ||
|
|
||
| fcmTokenWriter.deleteAll(tokens); | ||
| failedResponse.removeFailedWith404Tokens(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR의 목적이 무엇인가요?
전송에 실패한 알림에 대한 로깅 구체화
이슈 ID는 무엇인가요?
설명
[INFO ] 2024-10-24 11:28:09 - No Retryable tokens for title: 찐막 QA, body: 파스타: d, failed: [FcmToken{memberId=9, tokenId=0}, FcmToken{memberId=11, tokenId=0}].기존에는 위와 같이 재전송하지 않는 토큰들을 로깅하고 있었는데, 어떤 회원에게 전송이 안 되었는지 파악할 수는 있지만 어떤 오류인지는 파악이 안 되는 문제가 있었습니다.
따라서 기존처럼 토큰만 로깅하는게 아닌, 어떤 예외에 어떤 토큰이 있는지 조금 더 메시지를 구체화하도록 수정하였습니다.
질문 혹은 공유 사항 (Optional)