-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
웹 접근성 개선 #693
Merged
Merged
웹 접근성 개선 #693
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1ff79f6
feat: 문서 한국어로 변경 및 og description 수정
cys4585 1b28aab
feat: 다락방 생성 및 참여 플로우 접근성 개선
cys4585 73abcb7
feat: 모임 만들기 접근성 개선 및 UX 개선
cys4585 0ff2f7b
style: 불필요한 로그 삭제
cys4585 ae1f18a
Merge branch 'develop-frontend' into feature/#692
jaeml06 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
frontend/src/components/Funnel/FunnelInputErrorMessage/FunnelInputErrorMessage.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
import { useTheme } from '@emotion/react'; | ||
import { HTMLAttributes, PropsWithChildren } from 'react'; | ||
|
||
interface FunnelInputErrorMessageProps | ||
extends HTMLAttributes<HTMLSpanElement> {} | ||
|
||
export default function FunnelInputErrorMessage( | ||
props: PropsWithChildren<FunnelInputErrorMessageProps>, | ||
) { | ||
const { children, ...rest } = props; | ||
|
||
const theme = useTheme(); | ||
|
||
return ( | ||
<span css={[theme.typography.b3]} {...rest}> | ||
{children} | ||
</span> | ||
); | ||
} |
10 changes: 6 additions & 4 deletions
10
frontend/src/components/Funnel/FunnelQuestion/FunnelQuestion.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 12 additions & 3 deletions
15
frontend/src/layouts/FunnelLayout/FunnelFooter/FunnelFooter.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,32 @@ | ||
import { PropsWithChildren, useEffect, useState } from 'react'; | ||
import * as S from './FunnelFooter.style'; | ||
|
||
export default function FunnelFooter(props: PropsWithChildren) { | ||
const { children } = props; | ||
interface FunnelFooterProps { | ||
isResize?: boolean; | ||
} | ||
|
||
export default function FunnelFooter( | ||
props: PropsWithChildren<FunnelFooterProps>, | ||
) { | ||
const { children, isResize = true } = props; | ||
const [keyboardHeight, setKeyboardHeight] = useState(0); | ||
|
||
useEffect(() => { | ||
if (!isResize) return; | ||
|
||
const handleResize = () => { | ||
if (window.visualViewport) { | ||
const keyboardHeight = | ||
window.innerHeight - window.visualViewport.height; | ||
setKeyboardHeight(Math.max(0, keyboardHeight)); | ||
console.log(Math.max(0, keyboardHeight)); | ||
} | ||
}; | ||
|
||
window.visualViewport?.addEventListener('resize', handleResize); | ||
return () => | ||
window.visualViewport?.removeEventListener('resize', handleResize); | ||
}, []); | ||
}, [isResize]); | ||
|
||
return <div css={S.container(keyboardHeight)}>{children}</div>; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.log 지워줘요잉~~~