채팅 알림 메시지 형식 수정 #651
Merged
채팅 알림 메시지 형식 수정 #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
베팅에서의 채팅도 알림 적용했어요 ~ 749ebdb |
ksk0605
approved these changes
Oct 16, 2024
Mingyum-Kim
approved these changes
Oct 16, 2024
| List<Recipient> recipients = chatRecipientFinder.getChatNotificationRecipients(moim.getId(), sender); | ||
| NotificationEvent notificationEvent = createNotificationEvent(moim, sender, notificationType, recipients, chatRoomId); | ||
| public void sendChatNotification( | ||
| long darakbangId, ChatRoom chatRoom, String content, DarakbangMember sender, NotificationType notificationType |
There was a problem hiding this comment.
DarakbangMember이 알림을 받는 사람일까요? 그렇다면 receiver가 맞을 것 같습니다 😀
ay-eonii
approved these changes
Oct 16, 2024
| notificationType, moim.getTitle(), message, urlConfig.getChatRoomUrl(moim.getDarakbangId(), chatRoomId), recipients, moim.getDarakbangId(), chatRoomId); | ||
| private static String confirmedChatMessage(String content, NotificationType type) { | ||
| if (type == NotificationType.MOIM_PLACE_CONFIRMED) { | ||
| return "장소가 '" + content + "' 로 확정되었어요!"; |
There was a problem hiding this comment.
Suggested change
| return "장소가 '" + content + "' 로 확정되었어요!"; | |
| return "장소가 '" + content + "' (으)로 확정되었어요!"; |
| ChatRoomType chatRoomType = chatRoom.getType(); | ||
| long chatRoomId = chatRoom.getId(); | ||
| if (chatRoomType == ChatRoomType.BET) { | ||
| Bet bet = betFinder.find(darakbangId, chatRoom.getTargetId()); |
hoyeonyy
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR의 목적이 무엇인가요?
채팅 알림의 메시지 형식을 수정했고, 예외가 발생할 수 있는 부분을 임시로 처리했습니다.
이슈 ID는 무엇인가요?
설명
채팅 메시지 형식은 다음과 같이 수정되었습니다.
기존의 ChatService에는 적용하지 않았고 새로 추가된 ChatRoom을 이용하는 ChatService에만 적용했습니다.
수정 전
수정 후
또한, chat 패키지에서 채팅 알림 관련 작업을 확인하던 중, 현재 채팅 로직이 모임에만 한정되어 있다는 점을 확인했습니다.
(targetId가 같은 long이기 때문에 베팅 관련 알림임에도 모임이 조회되는 예외 발생 가능)
일단 해당 부분은 if문으로 처리하도록 막아놨어요~-> 기능 추가했습니다 ~
질문 혹은 공유 사항 (Optional)