-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
모임 참여 기능 구현 #61
모임 참여 기능 구현 #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고했어~
if (currentPeople == maxPeople) { | ||
throw new IllegalArgumentException(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?? 같아도 되는거 아닌가유
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 1 했을 때 현재 인원수가 더 크면 처리가 맞는거 같아요!
public void join() { | ||
if (currentPeople + 1 > maxPeople) { | ||
throw new IllegalArgumentException(); | ||
} | ||
currentPeople++; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR의 목적이 무엇인가요?
모임을 참여하는 기능을 구현한다.
이슈 ID는 무엇인가요?
설명
모임 참여 시 currentPeople이 증가되도록 구현함
질문 혹은 공유 사항 (Optional)
예외 핸들링 해야할 것 같습니다.