Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

모임 참여 기능 구현 #61

Merged
merged 4 commits into from
Jul 17, 2024
Merged

모임 참여 기능 구현 #61

merged 4 commits into from
Jul 17, 2024

Conversation

Mingyum-Kim
Copy link
Contributor

PR의 목적이 무엇인가요?

모임을 참여하는 기능을 구현한다.

이슈 ID는 무엇인가요?

설명

모임 참여 시 currentPeople이 증가되도록 구현함

질문 혹은 공유 사항 (Optional)

예외 핸들링 해야할 것 같습니다.

@Mingyum-Kim Mingyum-Kim added BE 백엔드 관련 이슈입니다. 🌱 기능추가 feature (새로운 기능 구현) labels Jul 17, 2024
@Mingyum-Kim Mingyum-Kim requested review from ksk0605 and hoyeonyy July 17, 2024 08:39
@Mingyum-Kim Mingyum-Kim self-assigned this Jul 17, 2024
Copy link
Contributor

@ksk0605 ksk0605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고했어~

Comment on lines 42 to 44
if (currentPeople == maxPeople) {
throw new IllegalArgumentException();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?? 같아도 되는거 아닌가유

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 1 했을 때 현재 인원수가 더 크면 처리가 맞는거 같아요!

Comment on lines +41 to +45
public void join() {
if (currentPeople + 1 > maxPeople) {
throw new IllegalArgumentException();
}
currentPeople++;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mingyum-Kim Mingyum-Kim merged commit a9b8b32 into develop-backend Jul 17, 2024
1 check passed
@Mingyum-Kim Mingyum-Kim deleted the feature/#58 branch July 17, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE 백엔드 관련 이슈입니다. 🌱 기능추가 feature (새로운 기능 구현)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants