채팅 데이터 생성 및 모임마다의 전체 조회 기능 구현 #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ay-eonii
approved these changes
Aug 1, 2024
Comment on lines
13
to
14
| @NotNull Long moimId, | ||
| @NotBlank String content |
There was a problem hiding this comment.
통일성을 위해 어노테이션과 개행을 하는 건 어떤가요?
|
|
||
| public void createChat(ChatCreateRequest chatCreateRequest, Member member) { | ||
| Moim moim = moimRepository.findById(chatCreateRequest.moimId()) | ||
| .orElseThrow(() -> new ChatException(HttpStatus.BAD_REQUEST, ChatErrorMessage.MOIM_NOT_FOUND)); |
There was a problem hiding this comment.
저는 모임이 없는 경우 (moim패키지가 아니더라도) MoimException을 발생시켰는데 , 이 부분에 대해 이야기하고 통일하면 좋을 것 같아요~
ksk0605
approved these changes
Aug 1, 2024
Comment on lines
8
to
10
| public enum ChatErrorMessage { | ||
| MOIM_NOT_FOUND("존재하지 않는 모임에 채팅할 수 없습니다."); | ||
|
|
Comment on lines
36
to
38
| .map(ChatFindDetailResponse::toResponse) | ||
| .toList(); | ||
| return new ChatFindUnloadedResponse(member.getId(), chats); |
There was a problem hiding this comment.
저는 띄어쓰기를 의미 단위로 자르는 걸 좋아하는데 리턴문과 채팅을 가져오는 단계를 구분하는 것은 어떤가요???
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR의 목적이 무엇인가요?
채팅 데이터 생성 및 모임마다의 전체 조회 기능을 구현하였습니다.
이슈 ID는 무엇인가요?
설명
우선 데이터베이스에 INSERT, SELECT 하는 방식으로 구현하였어요.
채팅을 조회할 때는 ""아직 조회되지 않은 채팅""을 필터링해서 목록을 클라이언트에게 보내줍니다.
질문 혹은 공유 사항 (Optional)