현재 모임 상태 태그구현 #142
Merged
현재 모임 상태 태그구현 #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cys4585
approved these changes
Jul 30, 2024
Comment on lines
+168
to
+174
| tag: css` | ||
| font-family: Pretendard; | ||
| font-size: 1.2rem; | ||
| font-style: normal; | ||
| font-weight: 600; | ||
| line-height: 130%; | ||
| `, |
There was a problem hiding this comment.
figma 디자인 시스템 typography에는 아직 tag에 대한 것은 적용되어 있지 않은 것 같아요!
@ksk0605 테바에게 공유가 되어야 할 것 같아요~
이번 케이스와 같이 개발을 하면서 필요할 것 같은 규칙이 있다면 추가하고 공유해드리면 될까요?
| render: (args) => <Tag {...args} />, | ||
| }; | ||
|
|
||
| export const RedTag: Story = { |
There was a problem hiding this comment.
정말 사소하지만 GreenTag, RedTag와 같이 색상을 표현하는 것보다 의미를 표현하면 어떨까요? (너무 사소한가?ㅋㅋ)
ss0526100
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR의 목적이 무엇인가요?
태그 컴포넌트 구현
props로 color를 받아 ( 'red' | 'green' | 'gray') 색상을 변경할 수 있는 태그 컴포넌트 구현
이슈 ID는 무엇인가요?
설명
질문 혹은 공유 사항 (Optional)