test: 예외 리팩토링에 따른 테스트 수정

woowacourse-teams · Oct 14, 2024 · a2a607f · a2a607f
1 parent d1d6c0a
commit a2a607f
Show file tree

Hide file tree

Showing 2 changed files with 112 additions and 110 deletions.
diff --git a/backend/src/test/java/mouda/backend/chat/implement/BetAttributeManagerTest.java b/backend/src/test/java/mouda/backend/chat/implement/BetAttributeManagerTest.java
@@ -23,118 +23,119 @@
 import mouda.backend.chat.domain.BetAttributes;
 import mouda.backend.chat.domain.ChatRoom;
 import mouda.backend.chat.domain.ChatRoomType;
+import mouda.backend.chat.exception.ChatException;
 import mouda.backend.darakbang.domain.Darakbang;
 import mouda.backend.darakbangmember.domain.DarakbangMember;
 
 class BetAttributeManagerTest {
 
-    @Mock
-    private BetFinder betFinder;
-
-    @Mock
-    private BetDarakbangMemberRepository betDarakbangMemberRepository;
-
-    @InjectMocks
-    private BetAttributeManager betAttributeManager;
-
-    @BeforeEach
-    void setUp() {
-        MockitoAnnotations.openMocks(this);
-    }
-
-    @DisplayName("안내면진다 채팅방을 지원한다.")
-    @Test
-    void support_shouldReturnTrueForBetType() {
-        // given
-        ChatRoomType chatRoomType = ChatRoomType.BET;
-
-        // when
-        boolean result = betAttributeManager.support(chatRoomType);
-
-        // then
-        assertThat(result).isTrue();
-    }
-
-    @DisplayName("안내면진다 채팅방이 아닌 채팅방은 지원하지 않는다.")
-    @Test
-    void support_shouldReturnFalseForNonBetType() {
-        // given
-        ChatRoomType chatRoomType = ChatRoomType.MOIM;
-
-        // when
-        boolean result = betAttributeManager.support(chatRoomType);
-
-        // then
-        assertThat(result).isFalse();
-    }
-
-    @DisplayName("안내면진다 어트리뷰트를 반환한다.")
-    @Test
-    void create_shouldReturnBetAttributes() {
-        // given
-        ChatRoom chatRoom = mock(ChatRoom.class);
-        DarakbangMember darakbangMember = mock(DarakbangMember.class);
-        Darakbang darakbang = mock(Darakbang.class);
-        Bet bet = mock(Bet.class);
-
-        when(chatRoom.getTargetId()).thenReturn(1L);
-        when(darakbangMember.getDarakbang()).thenReturn(darakbang);
-        when(darakbang.getId()).thenReturn(1L);
-
-        when(betFinder.find(1L, 1L)).thenReturn(bet);
-        when(bet.getBetDetails()).thenReturn(new BetDetails(1L, "test bet", LocalDateTime.of(2024, 6, 5, 12, 3)));
-        when(bet.isLoser(darakbangMember.getId())).thenReturn(true);
-        when(bet.getId()).thenReturn(1L);
-        when(bet.getLoserId()).thenReturn(2L);
-        when(bet.getMoimerId()).thenReturn(1L);
-
-        DarakbangMember loserMember = mock(DarakbangMember.class);
-        when(loserMember.getNickname()).thenReturn("loserNick");
-        when(loserMember.getProfile()).thenReturn("profilePic");
-        BetEntity betEntity = BetEntity.builder()
-            .id(1L)
-            .bettingTime(LocalDateTime.now())
-            .title("test bet")
-            .moimerId(1L)
-            .loserDarakbangMemberId(2L)
-            .darakbangId(2L)
-            .build();
-        when(betDarakbangMemberRepository.findByBetIdAndDarakbangMemberId(1L, 2L))
-            .thenReturn(Optional.of(new BetDarakbangMemberEntity(loserMember, betEntity)));
-
-        // when
-        Attributes attributes = betAttributeManager.create(chatRoom, darakbangMember);
-
-        // then
-        assertThat(attributes).isInstanceOf(BetAttributes.class);
-        BetAttributes betAttributes = (BetAttributes)attributes;
-        assertThat(betAttributes.isLoser()).isTrue();
-        assertThat(betAttributes.getBetId()).isEqualTo(1L);
-        assertThat(betAttributes.getLoser().getNickname()).isEqualTo("loserNick");
-        assertThat(betAttributes.getLoser().getProfile()).isEqualTo("profilePic");
-    }
-
-    @DisplayName("참여하지 않는 안내면진다의 어트리뷰트를 요청하면 예외를 발생한다.")
-    @Test
-    void create_shouldThrowExceptionWhenLoserNotFound() {
-        // given
-        ChatRoom chatRoom = mock(ChatRoom.class);
-        DarakbangMember darakbangMember = mock(DarakbangMember.class);
-        Darakbang darakbang = mock(Darakbang.class);
-        Bet bet = mock(Bet.class);
-
-        when(chatRoom.getTargetId()).thenReturn(1L);
-        when(darakbangMember.getDarakbang()).thenReturn(darakbang);
-        when(darakbang.getId()).thenReturn(1L);
-
-        when(betFinder.find(1L, 1L)).thenReturn(bet);
-        when(bet.getLoserId()).thenReturn(2L);
-
-        when(betDarakbangMemberRepository.findByBetIdAndDarakbangMemberId(1L, 2L))
-            .thenReturn(Optional.empty());
-
-        // when & then
-        assertThatThrownBy(() -> betAttributeManager.create(chatRoom, darakbangMember))
-            .isInstanceOf(IllegalArgumentException.class);
-    }
+	@Mock
+	private BetFinder betFinder;
+
+	@Mock
+	private BetDarakbangMemberRepository betDarakbangMemberRepository;
+
+	@InjectMocks
+	private BetAttributeManager betAttributeManager;
+
+	@BeforeEach
+	void setUp() {
+		MockitoAnnotations.openMocks(this);
+	}
+
+	@DisplayName("안내면진다 채팅방을 지원한다.")
+	@Test
+	void support_shouldReturnTrueForBetType() {
+		// given
+		ChatRoomType chatRoomType = ChatRoomType.BET;
+
+		// when
+		boolean result = betAttributeManager.support(chatRoomType);
+
+		// then
+		assertThat(result).isTrue();
+	}
+
+	@DisplayName("안내면진다 채팅방이 아닌 채팅방은 지원하지 않는다.")
+	@Test
+	void support_shouldReturnFalseForNonBetType() {
+		// given
+		ChatRoomType chatRoomType = ChatRoomType.MOIM;
+
+		// when
+		boolean result = betAttributeManager.support(chatRoomType);
+
+		// then
+		assertThat(result).isFalse();
+	}
+
+	@DisplayName("안내면진다 어트리뷰트를 반환한다.")
+	@Test
+	void create_shouldReturnBetAttributes() {
+		// given
+		ChatRoom chatRoom = mock(ChatRoom.class);
+		DarakbangMember darakbangMember = mock(DarakbangMember.class);
+		Darakbang darakbang = mock(Darakbang.class);
+		Bet bet = mock(Bet.class);
+
+		when(chatRoom.getTargetId()).thenReturn(1L);
+		when(darakbangMember.getDarakbang()).thenReturn(darakbang);
+		when(darakbang.getId()).thenReturn(1L);
+
+		when(betFinder.find(1L, 1L)).thenReturn(bet);
+		when(bet.getBetDetails()).thenReturn(new BetDetails(1L, "test bet", LocalDateTime.of(2024, 6, 5, 12, 3)));
+		when(bet.isLoser(darakbangMember.getId())).thenReturn(true);
+		when(bet.getId()).thenReturn(1L);
+		when(bet.getLoserId()).thenReturn(2L);
+		when(bet.getMoimerId()).thenReturn(1L);
+
+		DarakbangMember loserMember = mock(DarakbangMember.class);
+		when(loserMember.getNickname()).thenReturn("loserNick");
+		when(loserMember.getProfile()).thenReturn("profilePic");
+		BetEntity betEntity = BetEntity.builder()
+			.id(1L)
+			.bettingTime(LocalDateTime.now())
+			.title("test bet")
+			.moimerId(1L)
+			.loserDarakbangMemberId(2L)
+			.darakbangId(2L)
+			.build();
+		when(betDarakbangMemberRepository.findByBetIdAndDarakbangMemberId(1L, 2L))
+			.thenReturn(Optional.of(new BetDarakbangMemberEntity(loserMember, betEntity)));
+
+		// when
+		Attributes attributes = betAttributeManager.create(chatRoom, darakbangMember);
+
+		// then
+		assertThat(attributes).isInstanceOf(BetAttributes.class);
+		BetAttributes betAttributes = (BetAttributes)attributes;
+		assertThat(betAttributes.isLoser()).isTrue();
+		assertThat(betAttributes.getBetId()).isEqualTo(1L);
+		assertThat(betAttributes.getLoser().getNickname()).isEqualTo("loserNick");
+		assertThat(betAttributes.getLoser().getProfile()).isEqualTo("profilePic");
+	}
+
+	@DisplayName("참여하지 않는 안내면진다의 어트리뷰트를 요청하면 예외를 발생한다.")
+	@Test
+	void create_shouldThrowExceptionWhenLoserNotFound() {
+		// given
+		ChatRoom chatRoom = mock(ChatRoom.class);
+		DarakbangMember darakbangMember = mock(DarakbangMember.class);
+		Darakbang darakbang = mock(Darakbang.class);
+		Bet bet = mock(Bet.class);
+
+		when(chatRoom.getTargetId()).thenReturn(1L);
+		when(darakbangMember.getDarakbang()).thenReturn(darakbang);
+		when(darakbang.getId()).thenReturn(1L);
+
+		when(betFinder.find(1L, 1L)).thenReturn(bet);
+		when(bet.getLoserId()).thenReturn(2L);
+
+		when(betDarakbangMemberRepository.findByBetIdAndDarakbangMemberId(1L, 2L))
+			.thenReturn(Optional.empty());
+
+		// when & then
+		assertThatThrownBy(() -> betAttributeManager.create(chatRoom, darakbangMember))
+			.isInstanceOf(ChatException.class);
+	}
 }
diff --git a/backend/src/test/java/mouda/backend/chat/implement/ParticipantResolverRegistryTest.java b/backend/src/test/java/mouda/backend/chat/implement/ParticipantResolverRegistryTest.java
@@ -12,6 +12,7 @@
 import org.mockito.MockitoAnnotations;
 
 import mouda.backend.chat.domain.ChatRoomType;
+import mouda.backend.chat.exception.ChatException;
 import mouda.backend.chat.implement.ParticipantResolverRegistry;
 import mouda.backend.chat.implement.ParticipantsResolver;
 
@@ -66,6 +67,6 @@ void getResolver_shouldThrowExceptionForUnsupportedChatRoomType() {
 
 		// then
 		assertThatThrownBy(() -> participantResolverRegistry.getResolver(chatRoomType))
-			.isInstanceOf(IllegalArgumentException.class);
+			.isInstanceOf(ChatException.class);
 	}
 }