-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE] 토스/카카오톡 앱이 없을 때 앱스토어로 이동할 수 있도록 개선 #873
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
import {isIOS, isMobileDevice} from '@utils/detectDevice'; | ||
|
||
import toast from '../hooks/useToast/toast'; | ||
|
||
type NavigateAppArgs = { | ||
android: AppUrl; | ||
ios: AppUrl; | ||
options?: NavigateAppOptions; | ||
}; | ||
|
||
type NavigateAppOptions = { | ||
delayBeforeCheckTime?: number; // 앱 실행 후 설치 여부를 확인하기 전까지의 대기 시간. | ||
installThresholdTime?: number; // 설치 여부를 판단하는 기준 시간. | ||
}; | ||
|
||
const DEFAULT_DELAY_BEFORE_CHECK_TIME = 1000; | ||
const DEFAULT_INSTALL_THRESHOLD_TIME = 1500; | ||
Comment on lines
+16
to
+17
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. constants 폴더에서 관리해줘도 좋을 것 같아요-! |
||
|
||
type AppUrl = { | ||
appScheme: string; | ||
storeUrl: string; | ||
}; | ||
|
||
const navigateApp = ({android, ios, options}: NavigateAppArgs) => { | ||
if (!isMobileDevice()) { | ||
toast.error('모바일 기기에서만 앱 실행이 가능해요\n 모바일 환경에서 이용해 주세요.'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 놓치기 쉬운 부분도 섬세하게 챙겨주는 거 진짜 👍🏻👍🏻 |
||
return; | ||
} | ||
|
||
const url = isIOS() ? ios.appScheme : android.appScheme; | ||
const storeUrl = isIOS() ? ios.storeUrl : android.storeUrl; | ||
|
||
const now = Date.now(); | ||
window.location.href = url; | ||
|
||
setTimeout(() => { | ||
if (Date.now() - now < (options?.installThresholdTime ?? DEFAULT_INSTALL_THRESHOLD_TIME)) { | ||
toast.error('앱이 설치되지 않았어요. 설치 후 이용해주세요'); | ||
window.location.href = storeUrl; | ||
} | ||
}, options?.delayBeforeCheckTime ?? DEFAULT_DELAY_BEFORE_CHECK_TIME); | ||
}; | ||
|
||
export default navigateApp; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분은 생각하지 못했었는데, 정말 꼼꼼하게 챙겨주셨네요!! 쵝오👍🏻