[BE] setting/s3-CloudFront 서비스 이전 #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehtjsv2
requested review from
jimi567,
J-I-H-O and
takoyakimchi
as code owners
ehtjsv2
commented
Dec 2, 2024
Comment on lines
-67
to
+64
| .key(KEY_PREFIX + newFilename) | ||
| .key(newFilename) |
There was a problem hiding this comment.
원래 하나의 버킷에 우테코의 모든 프로젝트가 관리 되었어서 패키지로 분리했었습니다.(/fiendogly/..)
이제는 반갑개만 관리되니 key_prefix 삭제했습니다
Test Results226 tests 226 ✅ 19s ⏱️ Results for commit c18eea9. ♻️ This comment has been updated with latest results. |
takoyakimchi
reviewed
Dec 2, 2024
Comment on lines
5
to
6
| endpoint: https://d3obq7hxojfffa.cloudfront.net/ | ||
| endpoint: https://d1m6m0er0dq0qo.cloudfront.net/ | ||
| key-prefix: friendogly/ |
There was a problem hiding this comment.
여기도 key-prefix 없어져야 하는게 맞나요?
There was a problem hiding this comment.
코드에서 없애서 영향은 안주지만, 오해할 수 있으니 없애겠습니다~!
J-I-H-O
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
개발 사항
전달 사항 (없으면 삭제해 주세요)