[AN] test : 클럽 필터 로직 테스트 #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinuemong
requested review from
dpcks0509,
junjange and
gaeun5744
as code owners
Test Results77 tests 77 ✅ 1s ⏱️ Results for commit ab66a24. ♻️ This comment has been updated with latest results. |
junjange
reviewed
Nov 9, 2024
Comment on lines
15
to
22
| @BeforeEach | ||
| fun setUp() { | ||
| clubFilterSelector = ClubFilterSelector() | ||
| } | ||
|
|
||
| @Test | ||
| fun `필터를 추가하면 ClubFilterSelector에 해당 필터가 추가되어야 한다`() { | ||
| clubFilterSelector = ClubFilterSelector() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
개발 사항
전달 사항 (없으면 삭제해 주세요)
initClubFilter()로직과 함께 사용하지 않으면currentSelectedFilters가 초기화 되지 않아서 null 값으로 저장되고 있었습니다.addFilter()에서 plus(1) 로직이 안먹어서 계속 null로 초기화 되는 문제 발생