[AN] 놀이터 서비스 기능 및 리팩토링 #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpcks0509
requested review from
jinuemong,
junjange and
gaeun5744
as code owners
Test Results60 tests 60 ✅ 1s ⏱️ Results for commit 4734f86. ♻️ This comment has been updated with latest results. |
junjange
previously approved these changes
Oct 23, 2024
Comment on lines
89
to
90
| if (getPlaygroundAlarmUseCase.invoke().getOrDefault(true)) { | ||
| createNotificationChannel(AlarmType.PLAYGROUND) |
There was a problem hiding this comment.
getPlaygroundAlarmUseCase() 이렇게도 쓸 수 있어요~~
Comment on lines
+39
to
+51
| is RecentPetNavigationAction.NavigateToOtherProfile -> { | ||
| val intent = | ||
| OtherProfileActivity.getIntent( | ||
| this, | ||
| id = navigateAction.memberId, | ||
| ) | ||
| startActivity(intent) | ||
| } | ||
|
|
||
| is RecentPetNavigationAction.NavigateToPetImage -> { | ||
| val intent = PetImageActivity.getIntent(this, navigateAction.petImageUrl) | ||
| startActivity(intent) | ||
| } |
gaeun5744
previously approved these changes
Oct 23, 2024
gaeun5744
approved these changes
Oct 23, 2024
takoyakimchi
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
개발 사항
service.mp4