[AN] refactor : 모임 요구사항 4차 적용 #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinuemong
requested review from
dpcks0509,
junjange and
gaeun5744
as code owners
jinuemong
force-pushed
the
refactor/club-detail
branch
from
59d368c to
0d656ed
Compare
Test Results60 tests 60 ✅ 1s ⏱️ Results for commit 0d656ed. |
gaeun5744
approved these changes
Oct 23, 2024
| @@ -206,6 +207,7 @@ | |||
| <string name="club_detail_delete_title">모임에서 나가겠습니까?</string> | |||
| <string name="club_detail_participate_fail">모임에 참가하지 못하였습니다.</string> | |||
| <string name="club_detail_delete_fail">방 나가기에 실패하였습니다.</string> | |||
| <string name="club_detail_subject">모임 상세</string> | |||
Comment on lines
+82
to
+88
| is ApiExceptionResponse -> { | ||
| if (exception.httpCode == 400) { | ||
| Result.failure(ClubParticipationExceptionDto) | ||
| } else { | ||
| Result.failure(exception.toData()) | ||
| } | ||
| } |
There was a problem hiding this comment.
에러로 분기처리하면,, 에러들의 상속관계를 다 숙지하고 when문을 써야해서 추후해 수정해야 할 것 같네요 🥲
junjange
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
개발 사항