Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

해시태그 목록 조회 기능 구현(issue #307) #308

Merged
merged 4 commits into from
Aug 16, 2024
Merged

해시태그 목록 조회 기능 구현(issue #307) #308

merged 4 commits into from
Aug 16, 2024

Conversation

le2sky
Copy link
Member

@le2sky le2sky commented Aug 16, 2024

구현 요약

해시태그 목록 조회 기능을 구현했습니다.

연관 이슈

참고

코드 리뷰에 RCA 룰을 적용할 시 참고해주세요.

헤더 설명
R (Request Changes) 적극적으로 반영을 고려해주세요
C (Comment) 웬만하면 반영해주세요
A (Approve) 반영해도 좋고, 넘어가도 좋습니다. 사소한 의견입니다.

@le2sky le2sky self-assigned this Aug 16, 2024
@le2sky le2sky added 🚛 백엔드 백엔드 관련 이슈 ⚒️ 기능 작업해야하는 기능 labels Aug 16, 2024
robinjoon
robinjoon approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@robinjoon robinjoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 아톰! 간단해서 특별히 남길 리뷰는 없네요! 수고하셨습니다~~

alstn113
alstn113 approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@alstn113 alstn113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

수정 사항 확인해주세요!

backend/src/main/java/develup/api/HashTagApi.java Outdated
@GetMapping("/hash-tags")
@Operation(summary = "해시태그 목록 조회 API", description = "해시태그 목록을 조회합니다.")
public ResponseEntity<ApiResponse<List<HashTagResponse>>> getHashTags() {
return ResponseEntity.ok(new ApiResponse<>(hashTagService.getHashTags()));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Request Changes]

분리해주세요!

lilychoibb
lilychoibb approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@lilychoibb lilychoibb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아톰 고생했어요 👍👍

Minjoo522
Minjoo522 approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@Minjoo522 Minjoo522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 아톰!
고생하셨습니다.
깔끔하게 잘 작성해주셔서 Approve 드립니다.

@le2sky le2sky merged commit 9f527c8 into main Aug 16, 2024
6 checks passed
@le2sky le2sky deleted the feat/#307 branch August 16, 2024 07:22
Minjoo522 pushed a commit that referenced this pull request Aug 19, 2024
@le2sky @Minjoo522
해시태그 목록 조회 기능 구현(issue #307) (#308)
e6b02df 
* feat: 해시태그 목록 조회 api 구현

* style: import문 최적화

* refactor: 메서드 호출 변수 할당
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilychoibb lilychoibb lilychoibb approved these changes

@Minjoo522 Minjoo522 Minjoo522 approved these changes

@alstn113 alstn113 alstn113 approved these changes

@robinjoon robinjoon robinjoon approved these changes

Assignees

@le2sky le2sky

Labels
⚒️ 기능 작업해야하는 기능 🚛 백엔드 백엔드 관련 이슈
Projects
🆙 데벨업 프로젝트
Status: 😎 DONE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

전체 해시 태그 조회 기능
5 participants
@le2sky @robinjoon @alstn113 @Minjoo522 @lilychoibb