내가 제출한 솔루션 리스트 조회 기능 구현 (issue #288) #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
le2sky
requested changes
Aug 13, 2024
Comment on lines
106
to
108
| public String getThumbnail() { | ||
| return mission.getThumbnail(); | ||
| } |
There was a problem hiding this comment.
[Approve]
이렇게 getter가 합쳐진 형태에서 네이밍이 고민되네요.
getMissionThumbnail이 제일 정확한 표현 같은데, 릴리의 의견은 어떤가요?
릴리의 선호에 따라 반영해주세요.
There was a problem hiding this comment.
반영했습니다👍 현재 상태에선 getter가 합쳐졌다는 것이 명확하진 않네요
| @@ -18,4 +18,6 @@ public interface SolutionRepository extends JpaRepository<Solution, Long> { | |||
| List<SolutionSummary> findCompletedSummaries(); | |||
|
|
|||
| Optional<Solution> findByMember_IdAndMission_IdAndStatus(Long memberId, Long missionId, SolutionStatus status); | |||
|
|
|||
| List<Solution> findByMember_IdAndStatus(Long memberId, SolutionStatus solutionStatus); | |||
There was a problem hiding this comment.
[Request Changes]
반환값이 리스트인 경우 findBy로 시작하면 다른 개발자가 혼란스러울 수 있어요.
findAll로 시작하는 것은 어떨까요?
There was a problem hiding this comment.
수정했어요! 신경 못 썼던 부분 봐주셔서 감사합니다 :)
robinjoon
approved these changes
Aug 14, 2024
backend/src/test/java/develup/application/solution/SolutionServiceTest.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/develup/application/solution/SolutionServiceTest.java
Outdated
Show resolved
Hide resolved
Minjoo522
approved these changes
Aug 14, 2024
le2sky
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현 요약
대시보드 페이지 - 내가 제출한 솔루션 리스트 조회 기능 구현
연관 이슈
참고
코드 리뷰에
RCA 룰을 적용할 시 참고해주세요.