[FEAT] 새로운 AWS 계정에서 Prod 환경 CI/CD 구축 #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
현재 상황
작업 방향
CD 추후 개선 방향
|
jhon3242
approved these changes
Nov 28, 2024
| @@ -3,15 +3,15 @@ | |||
| GREEN_PORT=$1 | |||
|
|
|||
| health_check_process() { | |||
| # 헬스 체크를 최대 5번 시도 (3초 간격) | |||
| # 헬스 체크를 최대 5번 시도 (5초 간격) | |||
There was a problem hiding this comment.
EC2 환경이 너프되면서, 더 긴 시간이 필요하다고 느꼈습니다. 그래서 5초로 늘렸습니다.
근데, 10초로 하든, 5초로 하든 두 번째 헬스 체크에서 통과하더라구요;;
그래서 3초로 해도 크게 문제 없을 것 같긴 합니다. 타칸은 다른 의견 있으신가요?
PgmJun
approved these changes
Nov 28, 2024
| needs: [ build ] | ||
| uses: ./.github/workflows/blue-green.yml | ||
| with: | ||
| self_hosted_runner: prod-a | ||
| self_hosted_runner: prod |
There was a problem hiding this comment.
사소한 의견) Linux랑 X64까지 표기해줬으면 좋겠어요~
환경까지 구분 명확히 해주면 좋을 것 같아서요~ 저는 dev, X64, Linux 로 해뒀어용
There was a problem hiding this comment.
./.github/workflows/blue-green.yml에 값을 넘겨 주어 사용하는 것이다 보니, 환경까지 넘겨주기에는 최적화 되어있지 않네요;;
| @@ -3,15 +3,15 @@ | |||
| GREEN_PORT=$1 | |||
There was a problem hiding this comment.
의견) scripts 패키지 dev, prod 패키지로 한 번 더 구분하면 어떨까요? dev도 여기서 관리하고 싶은데
헷갈릴까봐 지금은 dev ec2 안에서 script 관리하고 있어요!
Dev도 굳이 인프라 안들어가고 여기서 관리하고 싶음요
There was a problem hiding this comment.
넵 그래서 스크립트를 scripts/prod/ 폴더로 옮겼습니다~
Comment on lines
+5
to
+8
| driver-class-name: com.mysql.cj.jdbc.Driver | ||
| url: jdbc:mysql://${secret.datasource.host}:${secret.datasource.port}/${secret.datasource.database}?useUnicode=true&characterEncoding=utf8&allowPublicKeyRetrieval=true&autoReconnect=true&serverTimezone=Asia/Seoul&useLegacyDatetimeCode=false | ||
| username: ${secret.datasource.username} | ||
| password: ${secret.datasource.password} |
| @@ -20,7 +14,7 @@ spring: | |||
| jpa: | |||
| database-platform: org.hibernate.dialect.MySQLDialect | |||
| hibernate: | |||
| ddl-auto: none | |||
| ddl-auto: validate | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#415
As-Is
To-Be
Check List
Test Screenshot
https://github.com/woowacourse-teams/2024-ddangkong/actions/runs/12048033899
정상적으로 Blue/Green 배포가 완료되는 것을 확인
(Optional) Additional Description