feat-be: 지원서 작성 완료 시 이메일 발송 기능 #960
Open
+62
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
xogns1514
reviewed
Dec 26, 2024
| @@ -68,6 +73,10 @@ public void submit(long applyFormId, ApplyFormSubmitRequest request) { | |||
| AnswerCreateRequest answerCreateRequest = getAnswerCreateRequest(question, answerCreateRequests); | |||
| answerService.saveAnswerReplies(answerCreateRequest, question, applicant); | |||
| } | |||
|
|
|||
| Club club = dashboard.getClub(); | |||
| Hibernate.initialize(club); | |||
There was a problem hiding this comment.
EmailService의 send 메서드에서 Club, Applicant를 매개변수로 받고 있더라고요.
Club을 그대로 전달하게 되면 다음과 같은 오류가 발생해서 이메일 전송에 실패합니다.
여기에서 강제 초기화해서 전달해두었습니다.!
유연성을 위해서 이메일 전송 발신자, 수신자를 String 매개변수로 하는건 어떨까 싶습니다?!
|
1735202171.885249 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
목적
작업 세부사항
참고 사항
다음과 같이 이메일이 전송됩니다.
EventListener 방식을 사용했습니다
EventListener를 사용한 이유는, 지원폼이 DB에 안정적으로 저장한 뒤에 이메일을 전송하는 것이 맞다고 생각했기 때문입니다. 기존
비동기 이메일 전송메서드를지원폼 작성메서드 내에서 호출하게 된다면, 지원폼이 저장되지 않았는데, 확인 이메일이 전송될 수 있는 문제점이 있다고 생각했기 때문입니다.APPLYFORM_EMAIL
closes #959