-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat-fe: 공고폼 임시 저장 기능 구현 #954
Open
github-actions
wants to merge
13
commits into
fe/develop
Choose a base branch
from
953-fe-auto-save-form
base: fe/develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jeongwoo Park <[email protected]>
lurgi
force-pushed
the
953-fe-auto-save-form
branch
from
December 24, 2024 02:03
c183a73
to
50a96ec
Compare
1735006390.590399 |
1735006392.370689 |
1735006394.880659 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue description
목적
작업 세부사항
참고 사항
auto-save-form
closes #953
⚒️ 변경사항
useDashboardCreateForm
및useLocalStorageState
훅에 대한 테스트를 강화.localStorage
값이 존재하는 경우 이전 작성 데이터를 복원하는 로직 테스트.localStorage
값이 없는 경우 초기값을 설정하고 동작하는지 검증.confirm
호출로 사용자가 선택에 따라 저장된 데이터를 유지 또는 초기화하는 로직 테스트.AppRouter
에서 발생한 중복 렌더링 문제로 인해DashboardCreate
페이지의 Lazy Loading을 임시적으로 제거해당 임포트를 일반적인 동기 방식으로 변경하여 문제를 해결
동적임포트를 사용하면 Confirm 로직이 4번 나타납니다. (예상값은 Strict Mode로 2번)
아래는 동적 임포트 사용시 4번 Confirm 로직이 발생되는 부분 캡쳐
2024-12-24.11.06.36.mov
dashboardHandlers
에서clubId
가 누락된 요청을 처리하도록 수정.💬 논의 사항