feat-fe: 모집 공고 탭 스크린 리더 개선 #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
1729747083.046679 |
|
1729747091.098929 |
|
1729747092.404149 |
|
1729747094.972569 |
llqqssttyy
approved these changes
Oct 24, 2024
| @@ -78,7 +78,7 @@ export default function ApplyForm({ questions, isClosed }: ApplyFormProps) { | |||
| return ( | |||
| <C.ContentContainer> | |||
| <S.Form onSubmit={handleSubmit}> | |||
| <S.AriaCustomQuestion aria-label={`총 ${questions.length}의 입력 중 1번째 입력입니다.`}> | |||
| <S.AriaCustomQuestion aria-label={`총 ${questions.length + 3}의 입력 중 1번째 입력입니다.`}> | |||
seongjinme
approved these changes
Oct 24, 2024
| @@ -78,7 +78,7 @@ export default function ApplyForm({ questions, isClosed }: ApplyFormProps) { | |||
| return ( | |||
| <C.ContentContainer> | |||
| <S.Form onSubmit={handleSubmit}> | |||
| <S.AriaCustomQuestion aria-label={`총 ${questions.length}의 입력 중 1번째 입력입니다.`}> | |||
| <S.AriaCustomQuestion aria-label={`총 ${questions.length + 3}의 입력 중 1번째 입력입니다.`}> | |||
llqqssttyy
pushed a commit
that referenced
this pull request
Oct 24, 2024
Co-authored-by: Jeongwoo Park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue description
목적
작업 세부사항
참고 사항
SR_POST
closes #930
모집 공고 부분에서 TextEditor는 스크린 리더 개선이 어려워, 제목, 날짜 정도 알려주는 태그만 넣었습니다! 간단한 수정만 했어요! 추가적으로 필요한 기능 있다면 알려주세요!