Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-fe: process 요청이 여러 번 가는 버그 #904

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 23, 2024

Original issue description

목적

사이드바에서 발생하는 버그를 해결합니다.

작업 세부사항

  • 사이드바에서 공고를 클릭하는 경우 dashboard 요청이 여러 번 가는 버그를 픽스합니다.

아래의 별표줄 밑에 요구사항 ID만 작성해주세요. Prefix 금지!


FIX_SIDE_02

closes #903

@github-actions github-actions bot added fix 버그 수정 frontend 프론트엔드 labels Oct 23, 2024
@github-actions github-actions bot added this to the 스프린트 6.0 milestone Oct 23, 2024
@llqqssttyy llqqssttyy changed the title fix-fe: 사이드 바 QA fix-fe: process 요청이 여러 번 가는 버그 Oct 23, 2024
@llqqssttyy llqqssttyy requested review from seongjinme and lurgi and removed request for seongjinme October 23, 2024 09:49
@llqqssttyy llqqssttyy marked this pull request as ready for review October 23, 2024 09:49
Copy link
Contributor Author

1729677005.966769

Copy link
Contributor Author

1729677006.723319

Copy link
Contributor Author

1729677008.243339

Copy link
Contributor Author

1729677016.334319

Copy link
Contributor Author

1729677018.028019

Copy link
Contributor

@seongjinme seongjinme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

렛서, 러기 두분 모두 다 너무나 고생하셨어요. 일단 useProcess를 여기저기서 불러오던 기존 코드 대신 prop drilling으로 프로세스 상태를 맞추신 결정에 공감합니다. queryKey 문제와 정체불명(?)의 process 재요청 건에 대해서는 저도 틈 날 때 계속 살펴볼게요... 😢

Copy link
Contributor

@lurgi lurgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

렛서 고생했어용 고생했어용 고생했어용

@llqqssttyy llqqssttyy merged commit fd406bc into fe/develop Oct 23, 2024
41 of 43 checks passed
@llqqssttyy llqqssttyy deleted the 903-fe-FIX_SIDE_02 branch October 23, 2024 10:02
seongjinme pushed a commit that referenced this pull request Oct 23, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kim Da Eun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 버그 수정 frontend 프론트엔드
Projects
Status: 완료
Development

Successfully merging this pull request may close these issues.

3 participants