feat-fe: 로그인이 되어있을 시 대시보드로 리다이렉트 #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
1729659369.789389 |
|
1729659372.557189 |
|
1729659456.811939 |
seongjinme
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
새로 만들어주신 RedirectGuard 좋네요 👍
| @@ -25,9 +33,13 @@ export default function useClubId() { | |||
| localStorage.removeItem(CLUB_ID_KEY); | |||
| }; | |||
|
|
|||
| const clubId = useSyncExternalStore(subscribe, getSnapshot, getSnapshot); | |||
There was a problem hiding this comment.
처음 보는 React 훅이어서 공식 문서를 한참 들여다 봤네요 😅 내부적으로 필요한 데이터가 리액트 외부에 의존성을 가지고 있을 때 이를 간편하게 처리해주는 건가보네요. 렛서 덕분에 좋은 것을 새로 배워갑니다.
한 가지 궁금한 점이 있는데, 이 훅의 3번째 인자는 getServerSnapshot로써 SSR과 Hydration을 위한 optional 인자로 알고 있어요. 여기에도 똑같이 getSnapshot을 넣어주신 이유가 궁금해요!
There was a problem hiding this comment.
제가 생각해도 필요 없는 인자라 제거했습니다! 꼼꼼하게 봐주셔서 감사해요~
lurgi
approved these changes
Oct 23, 2024
seongjinme
pushed a commit
that referenced
this pull request
Oct 23, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kim Da Eun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
목적
참고사항
useSyncExternalStore사용해useClubId리팩토링이번 작업에서는 useClubId 훅을 useSyncExternalStore로 리팩토링하여, localStorage의 clubId 상태를 실시간으로 동기화하도록 개선했습니다.
로그인 페이지에서 clubId 존재 여부에 따라 조건부 렌더링이 필요했지만, localStorage는 React 상태와 직접 연결되지 않으므로 값의 변화를 감지하려면 useEffect를 활용한 동기화가 필요했습니다. 이러한 로직을 SignIn 컴포넌트가 직접 관리하지 않도록, useClubId 훅으로 추상화했습니다.
useSyncExternalStore는 구독-알림 패턴을 통해 외부 데이터(localStorage)와 React 상태를 실시간으로 동기화할 수 있으므로, 이를 적용해 동기화 로직을 간소화했습니다.
SIGN_IN_02
closes #898