feat-be: 이메일 인증 후, 회원가입 이메일의 인증 여부 확인 #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
1729582626.285269 |
📌 Test Coverage Report
|
Dobby-Kim
requested changes
Oct 22, 2024
|
|
||
| public static VerificationStatus fromString(String status) { | ||
| try { | ||
| return VerificationStatus.valueOf(status); |
There was a problem hiding this comment.
valueOf() 보다 Enum 객체가 String value field를 가지게 하는건 어떨까요?
stream으로 찾아서 같은 값을 가진 enum을 return 해주고, 없으면 NOT_VERIFIED를 return 해주는 방식으로요!
특정 예외를 catch하는 것보다 안정성이 있어보여서 제안 드렸습니다 :>
xogns1514
approved these changes
Oct 22, 2024
Dobby-Kim
approved these changes
Oct 22, 2024
Dobby-Kim
pushed a commit
that referenced
this pull request
Oct 23, 2024
Co-authored-by: Kwoun Ki Ho <[email protected]>
Dobby-Kim
pushed a commit
that referenced
this pull request
Oct 23, 2024
Co-authored-by: Kwoun Ki Ho <[email protected]>
Dobby-Kim
pushed a commit
that referenced
this pull request
Oct 23, 2024
Co-authored-by: Kwoun Ki Ho <[email protected]>
Merged
Dobby-Kim
added a commit
that referenced
this pull request
Oct 23, 2024
fix-be: applicantCard 조회 시 평가 점수와 갯수가 모든 프로세스에 대해 나오는 버그 수정 (#902) fix-be: 이메일 인증 시 이미 가입된 이메일은 예외를 던지도록 변경 (#906) feat-be: RTR 방식 Redis로 변경 (#889) feat-be: 이메일 전송 템플릿 적용 (#897) feat-be: 이메일 인증 후, 회원가입 이메일의 인증 여부 확인 (#882) refactor-be: 식별자에 Tsid 적용 (#856) feat-be: 이메일 전송 로직 중 지원자 일괄 조회 로직 구현 (#869) fix-be: github action의 Redis 환경 변수 추가 (#871) feat-be: 이메일 인증 기능 구현 (#848)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue description
목적
작업 세부사항
EMAIL_VALID_02
closes #881