feat-fe: 메세지 제출 폼 및 사이드 모달 컴포넌트 구현 #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
1727324708.612699 |
|
1727324711.052329 |
|
1727324725.316279 |
lurgi
requested review from
llqqssttyy and
seongjinme
and removed request for
llqqssttyy and
seongjinme
seongjinme
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
러기 고생하셨어요. 상당히 빠듯한 일정이었는데 빠르게 구현해주셨네요. 로컬에서 대시보드 만들고 메일 전송하는 테스트도 해보았는데 다행히 잘 작동하네요.
일단 Approve 드릴게요. 다만 아래 사항들에 대해서는 데모데이 이후에 같이 논의해보면 좋을 것 같아요.
- 제목 500자, 내용 2,000자로 제한해 주셨는데요. 이 글자수가 공고 지원 화면에서처럼 표기가 되도록 개선되면 더 좋을 것 같아요.
- 위의 글자수 제한이 백엔드 레벨에서의 검증 조건과는 조금 달라서, 이에 대한 일치화 작업이 필요할지에 대해서는 백엔드 분들과 같이 이야기 나눠보면 좋을 것 같아요.
Comment on lines
+25
to
+27
| const [subjectError, setSubjectError] = useState<string | undefined>(undefined); | ||
| const [content, setContent] = useState(''); | ||
| const [contentError, setContentError] = useState<string | undefined>(undefined); |
There was a problem hiding this comment.
오 에러 메시지에 대해서 string과 undefined 타입을 같이 써주셨네요. 에러가 없다는 상태에 대해 명시적으로 표기하기 위해 써주신 거라고 이해하면 될까요?
There was a problem hiding this comment.
그런 것 같네요. 저는 값이 존재하지 않는다는 의미로 null로 선언하는 것도 괜찮을 것 같은데 러기는 어떻게 생각하시나요?
llqqssttyy
approved these changes
Sep 26, 2024
| @@ -34,7 +34,7 @@ export default class APIClient implements APIClientType { | |||
| return this.request<T>({ method: 'GET', ...params }); | |||
| } | |||
|
|
|||
| async post<T>(params: APIClientParamsWithBody): Promise<T> { | |||
| async post<T>(params: APIClientParamsWithBody & { isFormData?: boolean }): Promise<T> { | |||
There was a problem hiding this comment.
앞으로 확장성 있는 APIClient를 만들 땐 formData 타입도 유의해야겠네요..💭
Comment on lines
+25
to
+27
| const [subjectError, setSubjectError] = useState<string | undefined>(undefined); | ||
| const [content, setContent] = useState(''); | ||
| const [contentError, setContentError] = useState<string | undefined>(undefined); |
There was a problem hiding this comment.
그런 것 같네요. 저는 값이 존재하지 않는다는 의미로 null로 선언하는 것도 괜찮을 것 같은데 러기는 어떻게 생각하시나요?
Co-authored-by: Seongjin Hong <[email protected]>
Co-authored-by: Seongjin Hong <[email protected]>
llqqssttyy
pushed a commit
that referenced
this pull request
Sep 27, 2024
Co-authored-by: Jeongwoo Park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue description
목적
작업 세부사항
참고 사항
COM_MESSAGE
closes #700