-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix-fe: Date Picker 버그 수정 #676
Conversation
1726809976.604899 |
1726809977.546799 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
러기 빠른 수정에 감사드립니다. required
속성을 DateInput
이 아니라 이걸 가져다 쓰는 쪽에서 부여했으면 좋겠다는 코멘트를 남기던 차에 이걸 미리 수정해 주셨네요 ㅋㅋ 수고하셨어요!
const handleStartDate = (e: React.ChangeEvent<HTMLInputElement>) => { | ||
setRecruitmentInfoState((prev) => ({ | ||
...prev, | ||
startDate: new Date(e.target.value).toISOString(), | ||
startDate: e.target.value ? new Date(e.target.value).toISOString() : '', | ||
})); | ||
}; | ||
|
||
const handleEndDate = (e: React.ChangeEvent<HTMLInputElement>) => { | ||
setRecruitmentInfoState((prev) => ({ | ||
...prev, | ||
endDate: new Date(e.target.value).toISOString(), | ||
endDate: e.target.value ? new Date(e.target.value).toISOString() : '', | ||
})); | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -48,14 +48,14 @@ export default function Recruitment({ recruitmentInfoState, setRecruitmentInfoSt | |||
const handleStartDate = (e: React.ChangeEvent<HTMLInputElement>) => { | |||
setRecruitmentInfoState((prev) => ({ | |||
...prev, | |||
startDate: new Date(e.target.value).toISOString(), | |||
startDate: e.target.value ? new Date(e.target.value).toISOString() : '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아하~ 요놈이 문제였군요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
빠른 픽스 감사합니다 러기~
value가 존재하지 않을 때 기본값을 빈 문자열로 지정해줘야 하는군요?
덕분에 배웠습니다.
1726818451.682619 |
Co-authored-by: Jeongwoo Park <[email protected]>
Original issue description
목적
작업 세부사항
참고 사항
FIX_DATE_PICKER
closes #675