Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore-fe: Sentry Beta 추가 #589

Merged
merged 4 commits into from
Aug 22, 2024
Merged

chore-fe: Sentry Beta 추가 #589

merged 4 commits into from
Aug 22, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 21, 2024

Original issue description

목적

Sentry Beta 추가

작업 세부사항

  • Beta Url 추가

참고 사항

아래의 별표줄 밑에 요구사항 ID만 작성해주세요. Prefix 금지!


ADD_SENTRY_URL

closes #588

env설정 부탁드려용

@github-actions github-actions bot added chore 빌드 업무 수정, 패키지 관리자 구성 등 업데이트, Production Code 변경 없음 frontend 프론트엔드 labels Aug 21, 2024
Copy link
Contributor Author

1724236150.039899

Copy link
Contributor Author

1724236151.916879

@lurgi lurgi marked this pull request as ready for review August 21, 2024 10:35
Copy link
Contributor Author

1724236531.884809

Copy link
Contributor

@llqqssttyy llqqssttyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경 감사합니다~ url 관련해서 코멘트 하나 남겼으니 확인해주세요.

import globalStyles from './styles/globalStyles';
import theme from './styles/theme';

import AppRouter from './router/AppRouter';

const PROD_URL = 'https://www.cruru.kr';
const DEV_URL = 'https://beta.cruru.kr';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev는 환경변수 처리해주세요!

@lurgi lurgi merged commit c4c9b77 into fe/develop Aug 22, 2024
1 check passed
@lurgi lurgi deleted the fe-588-ADD_SENTRY_URL branch August 22, 2024 09:09
seongjinme pushed a commit that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 빌드 업무 수정, 패키지 관리자 구성 등 업데이트, Production Code 변경 없음 frontend 프론트엔드
Projects
Status: 완료
Development

Successfully merging this pull request may close these issues.

3 participants