-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore-fe: Sentry Beta 추가 #589
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
빌드 업무 수정, 패키지 관리자 구성 등 업데이트, Production Code 변경 없음
frontend
프론트엔드
labels
Aug 21, 2024
1724236150.039899 |
1724236151.916879 |
1724236531.884809 |
seongjinme
approved these changes
Aug 21, 2024
llqqssttyy
requested changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
변경 감사합니다~ url 관련해서 코멘트 하나 남겼으니 확인해주세요.
frontend/src/main.tsx
Outdated
import globalStyles from './styles/globalStyles'; | ||
import theme from './styles/theme'; | ||
|
||
import AppRouter from './router/AppRouter'; | ||
|
||
const PROD_URL = 'https://www.cruru.kr'; | ||
const DEV_URL = 'https://beta.cruru.kr'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dev는 환경변수 처리해주세요!
llqqssttyy
approved these changes
Aug 22, 2024
seongjinme
pushed a commit
that referenced
this pull request
Aug 23, 2024
Co-authored-by: Jeongwoo Park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue description
목적
작업 세부사항
참고 사항
ADD_SENTRY_URL
closes #588
env설정 부탁드려용