feat-fe: Toast구현 #570
Merged
feat-fe: Toast구현 #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
1724225170.163889 |
|
1724225179.002239 |
seongjinme
approved these changes
Aug 21, 2024
Comment on lines
+80
to
+81
| message: | ||
| 'Primary Alert Primary Alert Primary Alert Primary Alert! Primary Alert Primary Alert Primary Alert Primary Alert Primary Alert Primary Alert Primary Alert Primary !!! Alert Primary Alert Primary Alert Primary Alert Primary Alert Primary', |
Comment on lines
+23
to
+32
| const handleAlert = useCallback( | ||
| (type: ToastType) => (message: string) => { | ||
| const id = idRef.current; | ||
| setToastList((prev) => [...prev, { id, type, message }]); | ||
| idRef.current += 1; | ||
|
|
||
| setTimeout(() => removeToast(id), 4000); | ||
| }, | ||
| [], | ||
| ); |
There was a problem hiding this comment.
setTimeout과 연계해서 toast id값을 다룰 때 state 대신 ref로 구현하신 부분에 대해서 추후 자세한 설명을 요청드리고 싶어요. 어떠한 원리로 인하여 state는 문제가 생기고 ref는 통과되는지 좀 더 살펴보고 싶습니다. 🙏
llqqssttyy
approved these changes
Aug 21, 2024
seongjinme
pushed a commit
that referenced
this pull request
Aug 23, 2024
Co-authored-by: Jeongwoo Park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue description
목적
작업 세부사항
참고 사항
TOAST
closes #569