-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat-fe: 지원서 단답형/장문형 입력 필드에 글자 수 제한 추가 #505
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1723967528.292789 |
1723967537.473269 |
2 tasks
lurgi
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
꼼꼼하시네용! 감사합니다~
llqqssttyy
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
점점 완성도가 올라가는 게 보여 뿌듯하네용.
고생하셨습니다!
seongjinme
added a commit
that referenced
this pull request
Aug 23, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Seongjin Hong <[email protected]> Co-authored-by: Seongjin Hong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue description
목적
작업 세부사항
참고 사항
APP_VIEW_04
목적
변경 사항
InputField
,TextField
의isLengthVisible
prop을 통해 정할 수 있습니다.CustomQuestion
컴포넌트로 묶인 경우에만 표시되도록 했습니다.참고 사항
InputField
,TextField
에서 입력한 값(value
)의 길이가 글자 수 요소에 반영되지 않는 이슈가 남아있습니다.참고 화면
수정 후 지원서 화면 예시
수정 후 InputField에서 글자 수와 에러 메시지 동시 출력 화면 예시
관련 이슈