Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] pairRoomController 테스트를 PairRoomAcceptance 테스트로 변경 #89

Merged
merged 3 commits into from
Jul 24, 2024
Merged

[BE] pairRoomController 테스트를 PairRoomAcceptance 테스트로 변경 #89

merged 3 commits into from
Jul 24, 2024

Conversation

reddevilmidzy
Copy link
Member

연관된 이슈

구현한 기능

  • controller 패키지에 있던 PairRoomController 테스트를 acceptance 패키지로 이동

상세 설명

  • port 설정을 accpetance에서 만든 것으로 이용하도록 변경
  • 매 메서드 실행마다 삭제 로직 추가

@reddevilmidzy reddevilmidzy changed the title refactor: pairRoomController 테스트를 PairRoomAcceptance 테스트로 변경 [BE] pairRoomController 테스트를 PairRoomAcceptance 테스트로 변경 Jul 24, 2024
@reddevilmidzy reddevilmidzy added 🧪 test 테스트 작업 ⚙️ refactor 리팩터링 작업 labels Jul 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 9b59fa2.

♻️ This comment has been updated with latest results.

@reddevilmidzy reddevilmidzy requested review from koust6u and yechop July 24, 2024 02:20
kelly6bf
kelly6bf approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@kelly6bf kelly6bf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥰

koust6u
koust6u approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@koust6u koust6u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reddevilmidzy reddevilmidzy merged commit 0610423 into BE/dev Jul 24, 2024
3 checks passed
@reddevilmidzy reddevilmidzy deleted the BE/refactor/#88-PairRoomController branch July 24, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koust6u koust6u koust6u approved these changes

@kelly6bf kelly6bf kelly6bf approved these changes

@JiHyeonL JiHyeonL JiHyeonL approved these changes

@yechop yechop Awaiting requested review from yechop

Assignees
No one assigned
Labels
⚙️ refactor 리팩터링 작업 🧪 test 테스트 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reddevilmidzy @JiHyeonL @kelly6bf @koust6u