[BE] 페어 이름 액세스코드로 방 조회 api, 방 이름 구현 #873
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yechop
changed the title
JiHyeonL
approved these changes
Oct 23, 2024
| String missionUrl | ||
| String missionUrl, | ||
|
|
||
| @Schema(description = "페어 이름 액세스 코드", example = "짓궂은프람과 언짢은레모네") |
JiHyeonL
approved these changes
Oct 23, 2024
reddevilmidzy
requested changes
Oct 23, 2024
| @@ -61,6 +66,7 @@ public String toString() { | |||
| ", missionUrl=" + missionUrl + | |||
| ", accessCode=" + accessCode + | |||
| ", easyAccessCode=" + easyAccessCode + | |||
| ", roomName=" + roomName + | |||
There was a problem hiding this comment.
hashCode랑 equals 에서도 roomName 추가해주세요!
Comment on lines
+81
to
+85
| @Operation(summary = "페어 이름 액세스 코드로 페어룸이 존재하는지 조회한다.") | ||
| @ApiResponse(responseCode = "200", description = "페어룸 존재 여부, 페어룸 접근 코드", content = @Content(mediaType = MediaType.APPLICATION_JSON_VALUE, | ||
| schema = @Schema(implementation = PairRoomExistByEasyAccessCodeResponse.class))) | ||
| ResponseEntity<PairRoomExistByEasyAccessCodeResponse> pairRoomExistsByEasyAccessCode(String easyAccessCode); | ||
|
|
There was a problem hiding this comment.
easyAccessCode 가 리퀘스트 파라미터로 넘어오는데 이부분도 이렇게 문서화 가능합니다!
변경 부탁드려요
|
|
||
| public RoomName(final String value) { | ||
| validateEmpty(value); | ||
| final String trimmedValue = value.trim(); |
There was a problem hiding this comment.
trim() 보다 strip() 요친구가 더 많은 공백을 제거해줍니다 !
참고
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연관된 이슈
구현한 기능
페어 이름 액세스코드로 페어룸의 존재여부 api
페어 이름으로 방 이름을 생성
방 이름 수정 api
상세 설명
페어 이름 액세스코드로 페어룸을 찾아보고 존재하면 액세스코드를 응답해줍니다
'페어 룸 액세스코드' '액세스코드' '페어 이름 접근 코드' 'easyAccessCode' 등 명칭이 약간 혼용되고 있어 통일이 필요합니다