로그에 헤더 정보 수정 및 컨테이너 정보 추가 #990
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeus6768
reviewed
Dec 26, 2024
| @@ -65,20 +67,27 @@ private void logResponse(HttpServletRequest request, HttpServletResponse respons | |||
| } | |||
|
|
|||
| private String getHeaderAsJson(ContentCachingRequestWrapper requestWrapper) { | |||
| Set<String> requiredHeaders = Set.of("origin", "host", "content-type"); | |||
There was a problem hiding this comment.
메서드 실행할 때마다 객체를 생성하는 대신, static final로 선언하면 어떨까요??
| return convertMapToJson(headersMap); | ||
| } | ||
|
|
||
| private String getHeaderAsJson(ContentCachingResponseWrapper responseWrapper) { | ||
| Set<String> requiredHeaders = Set.of("docker-hostname"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡️ 관련 이슈
close #989
📍주요 변경 사항
로그에 헤더가 너무 많아서 필요한 정보만 포함되도록 수정하였습니다.
실행중인 서버의 도커 컨테이너 정보가 response 로그에 포함되도록 수정하였습니다.
적혀있는 정보는 실행중인 도커의
컨테이너 ID입니다.🎸기타
🍗 PR 첫 리뷰 마감 기한
12/26 23:59