Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 좋아요 반 정규화로 인한 템플릿 좋아요 시 해당 템플릿의 ModifiedAt 변경 문제 #927

Merged
merged 11 commits into from
Dec 16, 2024
Merged

[BUG] 좋아요 반 정규화로 인한 템플릿 좋아요 시 해당 템플릿의 ModifiedAt 변경 문제 #927

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
112450a
fix(auditing): 좋아요, 카테고리, 공개범위 변경 시에는 ModifiedAt 변경되지 않게 수정
kyum-q Nov 20, 2024
254a89f
fix(test): 테스트 오류 수정
kyum-q Nov 20, 2024
ecd5c89
refactor(auditing): 공백 제거
kyum-q Nov 20, 2024
71095a5
refactor(auditing): isModified의 기본 값을 true로 하고 markUnModified()를 이용하도…
kyum-q Dec 2, 2024
a3b3a06
refactor(auditing): 좋아요했을 때는 ModifiedAt이 변경되지 않도록 변경
kyum-q Dec 2, 2024
83fe8f2
refactor(auditing): 좋아요/좋아요 취소일 때만 수정시간 변경되지 않도록 수정
kyum-q Dec 11, 2024
026007d
tset: 오타 수정
kyum-q Dec 14, 2024
a978a17
refactor(auditing): 수정시간 변경 할 수 있는 클래스 구현 및 사용
kyum-q Dec 14, 2024
f57a461
refactor(auditing): SkipModifiedAtBaseTimeEntity 클래스 명 변경
kyum-q Dec 15, 2024
72541f1
refactor(template): 템플릿 업데이트 메서드 호출 시 데이터 변경 사항 없어도 modifiedAt 업데이트
kyum-q Dec 15, 2024
6f7eefa
refactor(auditing): 메서드명 개선
kyum-q Dec 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions backend/src/main/java/codezap/global/auditing/BaseTimeEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,4 @@ private void postLoad() {
public void markUnModified() {
isModified = false;
}

public void markModified() {
isModified = true;
}
}
1 change: 0 additions & 1 deletion backend/src/main/java/codezap/template/domain/SourceCode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ public String getThumbnailContent() {
}

public void updateSourceCode(String filename, String content, Integer ordinal) {
template.markModifiedSourceCodes();
this.filename = filename;
this.content = content;
this.ordinal = ordinal;
Expand Down
7 changes: 0 additions & 7 deletions backend/src/main/java/codezap/template/domain/Template.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,6 @@ public Template(Member member, String title, String description, Category catego
}

public void updateTemplate(String title, String description, Category category, Visibility visibility) {
if (this.title.equals(title) && this.description.equals(description)) {
markUnModified();
}
this.title = title;
this.description = description;
this.category = category;
Expand All @@ -102,8 +99,4 @@ public void cancelLike() {
}
this.likesCount--;
}

public void markModifiedSourceCodes() {
markModified();
}
}
26 changes: 1 addition & 25 deletions backend/src/test/java/codezap/template/service/TemplateServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,31 +254,7 @@ void updateTemplateSuccess() {
}

@Test
@DisplayName("템플릿 수정 성공 : 일부 데이터가 수정됬을 경우 modifiedAt 변경되지 않음")
void updateTemplateVisibilitySuccessNotChangeModifiedAt() {
var member = memberRepository.save(MemberFixture.getFirstMember());
var category = categoryRepository.save(CategoryFixture.getFirstCategory());
var otherCategory = categoryRepository.save(CategoryFixture.get(member));
var template = templateRepository.save(TemplateFixture.get(member, category));
var beforeModifiedAt = template.getModifiedAt();
var request = new UpdateTemplateRequest(
template.getTitle(),
template.getDescription(),
List.of(),
List.of(),
List.of(),
otherCategory.getId(),
List.of(),
Visibility.PRIVATE
);
sut.update(member, template.getId(), request, category);
entityManager.flush();

assertThat(template.getModifiedAt()).isEqualTo(beforeModifiedAt);
}

@Test
@DisplayName("템플릿 수정 성공 : 일부 데이터가 수정됬을 경우 modifiedAt 변경")
@DisplayName("템플릿 수정 성공 : 데이터가 수정됬을 경우 modifiedAt 변경")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

맞춤법 실수가 있어요..!!

void updateTemplateSuccessChangeModifiedAt() {
var member = memberRepository.save(MemberFixture.getFirstMember());
var category = categoryRepository.save(CategoryFixture.getFirstCategory());
Expand Down
Loading