Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

태그가 중복 저장되는 버그 해결 #922

Merged
merged 2 commits into from
Nov 18, 2024
Merged

태그가 중복 저장되는 버그 해결 #922

merged 2 commits into from
Nov 18, 2024

Conversation

jminkkk
Copy link
Contributor

@jminkkk jminkkk commented Nov 15, 2024 •
edited
Loading

⚡️ 관련 이슈

close #921

📍주요 변경 사항

  1. 기존 로직은 태그 저장 시에 기존에 존재하는 태그만 체크합니다. 새로 저장하려는 태그에 중복이 있는 경우 모두 저장됩니다. 따라서 태그 이름에 제거 후 저장하도록 변경하였습니다.
  2. 태그 저장 메서드가 복잡하여 메서드를 추출하였습니다.

🎸기타

  1. TemplateTagService와 TagService의 분리가 필요해보입니다.

🍗 PR 첫 리뷰 마감 기한

11/17 18:00

@jminkkk jminkkk added bug 개발자가 의도하지 않은 상황 BE 백엔드 labels Nov 15, 2024
@jminkkk jminkkk added this to the 7차 스프린트 💭 milestone Nov 15, 2024
@jminkkk jminkkk self-assigned this Nov 15, 2024
kyum-q
kyum-q approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@kyum-q kyum-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

몰리 짱이네요 ~~~!!! 댓츠 굿

zeus6768
zeus6768 approved these changes Nov 16, 2024
View reviewed changes
Copy link
Contributor

@zeus6768 zeus6768 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

읽기 쉬운 코드 작성 좋아요 👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍

HoeSeong123
HoeSeong123 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@HoeSeong123 HoeSeong123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

꽤 중요한 부분인데 모두가 놓치고 있었네요!!
고생하셨습니다 몰리!👍

@kyum-q kyum-q merged commit cb61c8e into dev/be Nov 18, 2024
4 checks passed
@kyum-q kyum-q deleted the fix/921-duplicate-save-tag branch November 18, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HoeSeong123 HoeSeong123 HoeSeong123 approved these changes

@kyum-q kyum-q kyum-q approved these changes

@zeus6768 zeus6768 zeus6768 approved these changes

@zangsu zangsu Awaiting requested review from zangsu

Assignees

@jminkkk jminkkk

Labels
BE 백엔드 bug 개발자가 의도하지 않은 상황
Projects
2024-code-zap
Status: Weekend Done
Milestone
7차 스프린트 💭
Development

Successfully merging this pull request may close these issues.
4 participants
@jminkkk @zeus6768 @kyum-q @HoeSeong123