Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 채팅뷰 가로모드 대응 #612

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Conversation

chaehyuns
Copy link
Contributor

@chaehyuns chaehyuns commented Oct 22, 2024

📌 관련 이슈

close #611

✨ 작업 내용

  • 채팅뷰 가로모드 대응 (nested scroll)
  • 채팅 목록 title 길이 대응

📚 기타

2024-10-22.5.30.28.mov

@chaehyuns chaehyuns self-assigned this Oct 22, 2024
Copy link
Contributor

@Namyunsuk Namyunsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고많으셨습니당~👍👍

app:layout_constraintTop_toTopOf="@id/tv_title_text" />

<View
android:id="@+id/white_round_view"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이친구도 다른 View컴포넌트 처럼 네이밍을 view_xxx로 하는거 어떤가용?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아용~

Copy link
Contributor

@songpink songpink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고많으셨어요~ 제 부분도 고쳐주셔서 감사!!

@chaehyuns chaehyuns merged commit 4f33361 into develop Oct 22, 2024
3 checks passed
@chaehyuns chaehyuns deleted the feature/611-chatting-land branch October 22, 2024 08:48
fromitive pushed a commit that referenced this pull request Nov 28, 2024
* feat: 채팅 뷰 가로 모드 대응

* feat: 채팅방 목록 title 길이 대응

* refactor: 이름 변경
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ 채팅뷰 가로모드 대응
3 participants