[FE] 자동 로그인 버그 해결 및 메인 페이지 디자인 수정 #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
healim01
approved these changes
Nov 5, 2024
| @@ -51,7 +53,7 @@ const S = { | |||
|
|
|||
| background-color: ${({ bgColor }) => bgColor}; | |||
|
|
|||
| color: ${theme.palette.white}; | |||
| color: ${theme.palette.black}; | |||
There was a problem hiding this comment.
저희 여기는 왜 그냥 theme import 로 되어있을까용? 수정할 때 한번 수정되면 좋을거 같아요~!
내부에서 사용할 때는 useTheme 을 사용해보면 어떨까요? ThemeProvider 를 모두 사용하는 것에서 코드 통일성을 챙길 수 있을거 같아요~!
There was a problem hiding this comment.
오 컨벤션이 빠져 있군요 좋은 것 같네여!
Comment on lines
46
to
48
| :hover { | ||
| background-color: ${({ theme }) => theme.palette.green600}; | ||
| } |
skiende74
approved these changes
Nov 5, 2024
skiende74
reviewed
Nov 5, 2024
frontend/src/hooks/useAutoLogin.ts
Outdated
Comment on lines
15
to
24
| if (!isAccessTokenExist) { | ||
| try { | ||
| await postReissueAccessToken(); | ||
| const result = await getUserInfo(); | ||
| showToast({ message: `${result?.userName}님, 환영합니다.`, type: 'confirm' }); | ||
| return navigate(ROUTE_PATH.home); | ||
| await autoLogin(); | ||
| } catch (err) { | ||
| return await deleteToken(); | ||
| } | ||
| } else { | ||
| await autoLogin(); | ||
| } |
There was a problem hiding this comment.
if 내에서도 autoLogin()을 하고
else에서도 autoLogin()을 한다는 말은 항상할거라는 말인데
autoLogin을 그냥밖으로 빼내고 else문을 제거할수있을거같네요
if (!isAccessTokenExist) {
try {
await postReissueAccessToken();
} catch (err) {
return await deleteToken();
}
}
await autoLogin();
|
새로운 방 체크버튼 강조디자인이 적용되었네요. 메인페이지도 예쁜거 같습니다. 수고하셨습니다 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Issue
✨ 구현한 기능
헤일리 디자인이랑 위에 articleKeyword 부분이 다르긴한데, 후버했을 때 느낌도 보면 이게 더 예쁜 것 같더라고요! 이렇게 픽스해도 될까요??
(참고로 after 사진의 노란색 카드는 후버된 색상입니다)
📢 논의하고 싶은 내용
🎸 기타