[FE] checklist v1 변동사항을 메인 페이지 체크리스트 리스트 컴포넌트에 반영한다. #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
healim01
had a problem deploying
to
frontend-msw
GitHub Actions
Failure
ooherin
approved these changes
Oct 24, 2024
|
테스트만 확인해주세요~! |
skiende74
reviewed
Oct 24, 2024
| @@ -24,7 +24,7 @@ export const getChecklistDetail = async (id: number) => { | |||
|
|
|||
| export const getChecklists = async (isLikeFiltered: boolean = false) => { | |||
| const response = await fetcher.get({ | |||
| url: BASE_URL + (isLikeFiltered ? ENDPOINT.CHECKLISTS_LIKE : ENDPOINT.CHECKLISTS), | |||
| url: BASE_URL + (isLikeFiltered ? ENDPOINT.CHECKLISTS_LIKE : ENDPOINT.CHECKLISTS_V1), | |||
There was a problem hiding this comment.
ENDPOINT.CHECKLISTS_LIKE는 과거 API인데 얘도 V1으로 되는지 백엔드와 상의해서 되게끔해주세요
There was a problem hiding this comment.
말해놓았습니다 앞에 v1/만 붙이면 돼요 (백엔드 머지후)
|
테스트도 확인해주세요 |
…ng-ggood into feat/890-update-for-get-checklist-v1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Issue
✨ 구현한 기능
GET checklist v1 변동 사항 확인
바뀐 api 에 맞춰 체크리스트 컴포넌트 업데이트
📢 논의하고 싶은 내용
🎸 기타
@tsulocalize 백엔드 업데이트 할때 참고하라고 태그합니다.
확인하면 좋을 목 데이터 :
frontend/src/mocks/fixtures/checklistList.ts